Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Conversation

@staabm
Copy link

@staabm staabm commented Sep 1, 2016

like we already do in addFunction

like we already do in addFunction
@zf2timo
Copy link

zf2timo commented Sep 1, 2016

@staabm i think this is not a good solution. Either the Parameter should be removed, when it isn't needed anymore, or initial use case of the parameter should be recovered.

There where already an attempt to remove the parameter, but it was reverted, as you can see here:
staabm@2f9afa5

Maybe someone with the knowledge about the history, can suggest, what should be done with the Parameter.

@staabm
Copy link
Author

staabm commented Sep 1, 2016

I was trying to make things more consistent. I agree having this functionality implemented would be the best thing but as it stands right now we should document that the parameter doesnt has impact on the method call.

why this actually is the case - I dont know :-).

@staabm staabm closed this Jan 7, 2017
@staabm staabm deleted the patch-1 branch January 7, 2017 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants