From 4077028538ab73d5534c71cecb52568376ac1231 Mon Sep 17 00:00:00 2001 From: bnprss Date: Fri, 14 Aug 2015 11:59:32 +0200 Subject: [PATCH 1/2] HHVM complaining about wrong parameter According to php documentation http://php.net/manual/fr/soapclient.soapcall.php, __soapCall should take array instead of null parameters. HHVM 3.8.0 is complaining resulting a wrong result with message : Warning: __soapcall() expects parameter 3 to be array, NULL given in /zendframework/library/Zend/Soap/Client.php on line 1117 This PR work with hhvm & php --- src/Client.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Client.php b/src/Client.php index 850fcc96..2d9c1614 100644 --- a/src/Client.php +++ b/src/Client.php @@ -1111,8 +1111,8 @@ public function __call($name, $arguments) $result = $soapClient->__soapCall( $name, $this->_preProcessArguments($arguments), - null, /* Options are already set to the SOAP client object */ - (count($soapHeaders) > 0)? $soapHeaders : null, + array(), /* Options are already set to the SOAP client object */ + (count($soapHeaders) > 0)? $soapHeaders : array(), $this->soapOutputHeaders ); From b9e2137f7ad472c6ea52a5b97290606f3200488e Mon Sep 17 00:00:00 2001 From: bnprss Date: Fri, 14 Aug 2015 13:07:27 +0200 Subject: [PATCH 2/2] minor corrections correct /vendor/bin/php-cs-fixer fix -v --diff --dry-run --- src/Client.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Client.php b/src/Client.php index 2d9c1614..f28e3860 100644 --- a/src/Client.php +++ b/src/Client.php @@ -1111,8 +1111,8 @@ public function __call($name, $arguments) $result = $soapClient->__soapCall( $name, $this->_preProcessArguments($arguments), - array(), /* Options are already set to the SOAP client object */ - (count($soapHeaders) > 0)? $soapHeaders : array(), + [], /* Options are already set to the SOAP client object */ + (count($soapHeaders) > 0)? $soapHeaders : [], $this->soapOutputHeaders );