New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type attribute for the style element is not needed for HTML5 #143

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@matbech
Contributor

matbech commented Dec 16, 2017

The type attribute is not required for style.

This fixes the following warning from the HTML validator:
The type attribute for the style element is not needed and should be omitted.

matbech added some commits Dec 16, 2017

Fix: type attribute for the style element is not needed
The type attribute is not required for style.

This fixes the following warning from the HTML validator:
 The type attribute for the style element is not needed and should be omitted.
updated tests
updated tests
removed extra space
removed extra space
@froschdesign

This comment has been minimized.

Member

froschdesign commented Dec 18, 2017

@matbech

The type attribute is not required for style.

This is only true for HTML5, not for XHTML and HTML4.

But you can check the Doctype in a view helper:

$this->view->plugin('doctype')->isHtml5()
type is required for html4, xhtml
type is required for html4, xhtml

@matbech matbech changed the title from Fix: type attribute for the style element is not needed to Fix: type attribute for the style element is not needed for HTML5 Dec 18, 2017

@matbech matbech changed the title from Fix: type attribute for the style element is not needed for HTML5 to type attribute for the style element is not needed for HTML5 Dec 18, 2017

matbech added some commits Dec 18, 2017

type attribute is expected
the type attribute is expected because the tests run without the doctype plugin
@froschdesign

This comment has been minimized.

Member

froschdesign commented Dec 19, 2017

Thanks for the changes.
Now we need unit tests for the new behaviour. Check with and without the doctype HTML5.

@weierophinney

This comment has been minimized.

Member

weierophinney commented Dec 6, 2018

Closing, as the requested changes made ~1year ago have not been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment