New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct malformed git clone url in contributing guide. #159

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@EpocSquadron
Contributor

EpocSquadron commented Aug 7, 2018

This tripped me up on the way to contributing another documentation fix.

@samsonasik

This comment has been minimized.

Contributor

samsonasik commented Aug 8, 2018

using @ was seems already fine:

git clone git@github.com:zendframework/zend-view.git zfview
Cloning into 'zfview'...
remote: Counting objects: 24046, done.
remote: Total 24046 (delta 0), reused 0 (delta 0), pack-reused 24045
Receiving objects: 100% (24046/24046), 5.98 MiB | 1.01 MiB/s, done.
Resolving deltas: 100% (15445/15445), done.
@EpocSquadron

This comment has been minimized.

Contributor

EpocSquadron commented Aug 9, 2018

Earlier in the file it does use @ but this particular line had git:// which threw an error when I tried pasting it in to the terminal and using as-is.

@weierophinney weierophinney merged commit 2a3d011 into zendframework:master Dec 6, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 84.003%
Details

weierophinney added a commit that referenced this pull request Dec 6, 2018

@weierophinney

This comment has been minimized.

Member

weierophinney commented Dec 6, 2018

Thanks, @EpochSquadron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment