Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SetCookie::getFieldValue() always uses urlencode() for cookie values, even in case they are already encoded #2444

Closed
zfbot opened this Issue Sep 28, 2012 · 1 comment

Comments

Projects
None yet
2 participants

zfbot commented Sep 28, 2012

Jira Information

Original Issue:ZF2-108
Issue Type:Bug
Reporter:Denis Voytyuk
Created:12/04/11
Assignee:ralphschindler
Components:Zend\Http

Description

In the following line:

{{$fieldValue = $this->getName() . '=' . urlencode($this->getValue());}}

SetCookie::getFieldValue() ignores the fact that cookies may come already encoded (for example from responses). As a result they are double encoded in this method and become invalid.

zfbot commented Sep 28, 2012

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF2-108

Known GitHub users mentioned in the original message or comment:
@ralphschindler

@Maks3w Maks3w closed this in b8705f3 Nov 14, 2012

@gianarb gianarb pushed a commit to zendframework/zend-http that referenced this issue May 15, 2015

@Maks3w Maks3w Merge pull request zendframework/zendframework#2929 branch 'hotfix/fi…
…x-double-cookie-encoding' Close zendframework/zendframework#2444
e193ac7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment