Zend\Validate translations out of date #2536

Closed
zfbot opened this Issue Sep 28, 2012 · 7 comments

Comments

Projects
None yet
5 participants

zfbot commented Sep 28, 2012

Jira Information

Original Issue:ZF2-491
Issue Type:Bug
Reporter:RalfEggert
Created:08/22/12
Assignee:DASPRiD
Components:Zend\I18n Zend\Validator

Description

A couple of issues:

  1. I noticed that the validation message for Zend\Validator\Csrf is missing in the translation files under /resources/languages.
  2. There are messages for a validator Zend_Validate_Ccnum that does not exist in Zf2
  3. The messages for Zend_Validate_CreditCard have changed if I compare them with Zend\Validator\CreditCard
  4. Other issues may also be in there

I guess the whole file needs to be updated and all translation files as well.

Example file: https://github.com/zendframework/zf2/blob/master/resources/languages/en/Zend_Validate.php

Anyway, should the file not be called Zend_Validator.php?

zfbot commented Sep 28, 2012

(Originally posted by: RalfEggert on 08/22/12)

What about using the text identifier from the class instead of the message? Example

Instead of using

    "Value is required and can't be empty" => "Value is required and can't be empty",

we could use

    "isEmpty" => "Value is required and can't be empty",

zfbot commented Sep 28, 2012

(Originally posted by: RalfEggert on 08/22/12)

Translations for EmailAddress and Regex Validator also have changed and are not translated anymore.

zfbot commented Sep 28, 2012

(Originally posted by: RalfEggert on 08/24/12)

Same problem with the messages from Zend\Validate\Db\Abstract

zfbot commented Sep 28, 2012

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF2-491

Known GitHub users mentioned in the original message or comment:
@RalfEggert, @DASPRiD

Member

ralphschindler commented Feb 8, 2013

@DASPRiD can we close this issue?

Contributor

RalfEggert commented Feb 8, 2013

IIRC @localheinz is working on this.

Contributor

sasezaki commented Feb 21, 2013

Hi all. Anyone taking on this issue?
here is current diff , develop branch's scanned messageTemplates VS resources/languages/en/Zend_Validate.php
https://gist.github.com/sasezaki/5005702
sasezaki/zf2@4e7ee06

@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this issue May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/4183' 4eb4184

@weierophinney weierophinney added a commit to zendframework/zend-i18n-resources that referenced this issue May 28, 2015

@weierophinney weierophinney Merge branch 'hotfix/4183' 9cd1cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment