Commit 2567c32caa7fe102f26b2ab59962b4eec9fa292c breaks BC #3537

Closed
mwillbanks opened this Issue Jan 23, 2013 · 7 comments

Comments

Projects
None yet
3 participants
@mwillbanks
Contributor

mwillbanks commented Jan 23, 2013

I have not quite figured out why this actually breaks but I did a git bisect and found that the commit: 2567c32 causes the break in an existing application. Reverting this commit makes the existing app function as expected.

The following is the stack trace:
Fatal error: Uncaught exception 'Zend\Di\Exception\RuntimeException' with message 'Invalid instantiator of type "NULL" for "Zend\EventManager\SharedEventManagerInterface".' in /var/www/vendor/zendframework/zendframework/library/Zend/Di/Di.php:225
Stack trace:
#0 /var/www/vendor/zendframework/zendframework/library/Zend/Di/Di.php(154): Zend\Di\Di->newInstance('Zend\EventManag...', Array, true)
#1 /var/www/vendor/zendframework/zendframework/library/Zend/ServiceManager/Di/DiServiceFactory.php(105): Zend\Di\Di->get('Zend\EventManag...', Array)
#2 /var/www/vendor/zendframework/zendframework/library/Zend/ServiceManager/Di/DiAbstractServiceFactory.php(44): Zend\ServiceManager\Di\DiServiceFactory->get('Zend\EventManag...', Array, true)
#3 [internal function]: Zend\ServiceManager\Di\DiAbstractServiceFactory->createServiceWithName(Object(Zend\ServiceManager\ServiceManager), 'zendeventmanage...', 'Zend\EventManag...')
#4 /var/www/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php(726): call_user_func(Ar in /var/www/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php on line 733

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jan 23, 2013

Member

Yes, that's because the DiServiceInitializer tries to apply setter injection to all the instances produced by the Service manager.

I'm totally for removing the DiServiceInitializer (not the generic abstract factory btw)

Member

Ocramius commented Jan 23, 2013

Yes, that's because the DiServiceInitializer tries to apply setter injection to all the instances produced by the Service manager.

I'm totally for removing the DiServiceInitializer (not the generic abstract factory btw)

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jan 23, 2013

Member
@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jan 23, 2013

Member

Basically, the DiServiceInitializer gets attached to the ServiceManager when $config['di'] is defined. This is a huge bottleneck. Let's remove it before hitting stable!

Member

Ocramius commented Jan 23, 2013

Basically, the DiServiceInitializer gets attached to the ServiceManager when $config['di'] is defined. This is a huge bottleneck. Let's remove it before hitting stable!

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jan 23, 2013

Owner

Give me a PR @Ocramius and I'll review. My only concern is: will removing that line cause a different set of breakage?

Owner

weierophinney commented Jan 23, 2013

Give me a PR @Ocramius and I'll review. My only concern is: will removing that line cause a different set of breakage?

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jan 23, 2013

Member

@weierophinney not compared to current master. From what @mwillbanks said, this is dev-develop only

Member

Ocramius commented Jan 23, 2013

@weierophinney not compared to current master. From what @mwillbanks said, this is dev-develop only

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jan 23, 2013

Owner

@Ocramius Okay, then, go for it. :)

On Wed, Jan 23, 2013 at 8:37 AM, Marco Pivetta notifications@github.comwrote:

@weierophinney https://github.com/weierophinney not compared to current
master. From what @mwillbanks https://github.com/mwillbanks said, this
is dev-develop only


Reply to this email directly or view it on GitHubhttps://github.com/zendframework/zf2/issues/3537#issuecomment-12597824.

Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/

Owner

weierophinney commented Jan 23, 2013

@Ocramius Okay, then, go for it. :)

On Wed, Jan 23, 2013 at 8:37 AM, Marco Pivetta notifications@github.comwrote:

@weierophinney https://github.com/weierophinney not compared to current
master. From what @mwillbanks https://github.com/mwillbanks said, this
is dev-develop only


Reply to this email directly or view it on GitHubhttps://github.com/zendframework/zf2/issues/3537#issuecomment-12597824.

Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/

@mwillbanks

This comment has been minimized.

Show comment Hide comment
@mwillbanks

mwillbanks Jan 25, 2013

Contributor

Thanks!

Contributor

mwillbanks commented Jan 25, 2013

Thanks!

@mwillbanks mwillbanks closed this Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment