Wincache unexpected return value on internalGetItem #4552

Closed
sebdalink opened this Issue May 28, 2013 · 1 comment

Comments

Projects
None yet
2 participants

On internalGetItem function, the expected return value, when item isn't found on cache, is null.
But wincache_ucache_get return false when $key isn't found on cache, so $result has a wrong return value in this case.

Member

marc-mabe commented May 29, 2013

@sebdalink Thank you for reporting this!
From reading the documentation you are right -> $result needs to be set to null if $success is false.

I'll create a PR but I can't run tests for this adapter - It would be great if you can run the unit tests for this adapter.

@weierophinney weierophinney added a commit that referenced this issue Jun 12, 2013

@weierophinney weierophinney Merge pull request #4632 from marc-mabe/hotfix/4552
fixed #4552: Wincache::getItem() have to return NULL in cases of missing items
ca1780e

@weierophinney weierophinney added a commit that referenced this issue Jun 12, 2013

@weierophinney weierophinney Merge branch 'hotfix/4632'
Close #4632
Fixes #4552
62b22f5

@gianarb gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015

@marc-mabe marc-mabe fixed zendframework/zendframework#4552: Zend\Cache\Storage\Adapter\Wi…
…ncache::getItem() have to return NULL in cases of not found items
1958a73

@weierophinney weierophinney added a commit to zendframework/zend-cache that referenced this issue May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#4632 from marc-mabe/ho…
…tfix/4552


fixed zendframework/zendframework#4552: Wincache::getItem() have to return NULL in cases of missing items
599cbb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment