Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Typo in Zend / Cache / Storage / Adapter / RedisResourceManager #4804

Closed
Rockstar04 opened this issue Jul 10, 2013 · 1 comment

Comments

@Rockstar04
Copy link
Contributor

commented Jul 10, 2013

Zend / Cache / Storage / Adapter / RedisResourceManager :: getMayorVersion()

https://github.com/zendframework/zf2/blob/master/library/Zend/Cache/Storage/Adapter/RedisResourceManager.php#L515

Is this function really supposed to be named getMayorVersion as opposed to getMajorVersion ??

@Maks3w

This comment has been minimized.

Copy link
Member

commented Jul 14, 2013

Indeed.

Please send us a contribution:

  • Copy the method with the fixed name
  • Proxy the call to the old method to the new one.
  • Add @deprecated to the docblock of the old method.
Maks3w added a commit that referenced this issue Jul 15, 2013
@Maks3w Maks3w closed this in 5a5a6f1 Jul 15, 2013
Maks3w added a commit that referenced this issue Jul 15, 2013
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
Corrected the name of the function and provide a proxy for backwards compatibility. Refs zendframework/zendframework#4804
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.