Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Possible Typo in Zend / Cache / Storage / Adapter / RedisResourceManager #4804

Closed
Rockstar04 opened this Issue Jul 10, 2013 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

Rockstar04 commented Jul 10, 2013

Zend / Cache / Storage / Adapter / RedisResourceManager :: getMayorVersion()

https://github.com/zendframework/zf2/blob/master/library/Zend/Cache/Storage/Adapter/RedisResourceManager.php#L515

Is this function really supposed to be named getMayorVersion as opposed to getMajorVersion ??

Member

Maks3w commented Jul 14, 2013

Indeed.

Please send us a contribution:

  • Copy the method with the fixed name
  • Proxy the call to the old method to the new one.
  • Add @deprecated to the docblock of the old method.

@Maks3w Maks3w closed this in 5a5a6f1 Jul 15, 2013

Maks3w added a commit that referenced this issue Jul 15, 2013

gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015

Correct spelling of function getMajorVersion
Corrected the name of the function and provide a proxy for backwards compatibility. Refs zendframework/zendframework#4804

gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015

gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015

gianarb pushed a commit to zendframework/zend-cache that referenced this issue May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment