Zend\Db\TableGateway\Feature\FeatureSet::addFeature() at line 69 #4993

Closed
wja513 opened this Issue Aug 21, 2013 · 5 comments

5 participants

@wja513

$feature->setTableGateway($feature);
May shoud be:
$feature->setTableGateway($this->tableGateway);
Is a simple mistake?

@samsonasik

@ThaDafinser AbstractFeature extends AbstractTableGateway, so it already right ?

@ramunasd

@samsonasik no it's not, there still needs some check before assigning table gateway for feature instance

@samsonasik samsonasik referenced this issue Feb 25, 2014
Closed

Fixes #4993 #5868

@samsonasik

@ThaDafinser @ramunasd I created PR #5868 for it, hope it fixes the issue ...

@ramunasd

Can confirm it does. But checks looks too much excessive :)

@ralphschindler ralphschindler added this to the 2.2.6 milestone Mar 4, 2014
@weierophinney weierophinney pushed a commit that closed this issue Mar 4, 2014
@samsonasik samsonasik Fixes #4993 79904c5
@weierophinney weierophinney added a commit that referenced this issue Mar 4, 2014
@weierophinney weierophinney Merge branch 'hotfix/5868'
Close #5868
Fixes #4993
664f696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment