Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ServiceManager::has() when assigned non String or Array causes Undefine Notice errors #5395

Closed
franz-deleon opened this Issue Oct 31, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

franz-deleon commented Oct 31, 2013

When ServiceManager::has() is validated against non arrays or strings, it returns error notices but it should really just return false

@franz-deleon franz-deleon pushed a commit to franz-deleon/zf2 that referenced this issue Oct 31, 2013

Franz De Leon fix for issue #5395. I know its going to be deprecated but might as w…
…ell do a small patch right now
15da648

@franz-deleon franz-deleon added a commit to franz-deleon/zf2 that referenced this issue Nov 1, 2013

@franz-deleon franz-deleon Issue #5395: remove unnecessary can create function and add logic to …
…has()
673aa86
Owner

weierophinney commented Nov 1, 2013

@franz-deleon Please send 15da648 as a PR -- that one looks correct, and maintains the canCreate() method.

Owner

weierophinney commented Nov 1, 2013

Closed via #5396.

@gianarb gianarb pushed a commit to zendframework/zend-servicemanager that referenced this issue May 15, 2015

Franz De Leon fix for issue zendframework/zendframework#5395. I know its going to b…
…e deprecated but might as well do a small patch right now
e71908f

@gianarb gianarb pushed a commit to zendframework/zend-servicemanager that referenced this issue May 15, 2015

@franz-deleon franz-deleon Issue zendframework/zendframework#5395: remove unnecessary can create…
… function and add logic to has()
e61cf17

@weierophinney weierophinney added a commit to zendframework/zend-servicemanager that referenced this issue May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#5396 from franz-deleon…
…/develop

Fix for issue zendframework/zendframework#5395
be837f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment