[http] Normalize Content-Transfer-Encoding #5665

Closed
Maks3w opened this Issue Jan 2, 2014 · 6 comments

Comments

Projects
None yet
3 participants
Member

Maks3w commented Jan 2, 2014

Appply the same changes as #5598 for to have the value normalized with lowercase

Contributor

denis-sokolov commented Jan 2, 2014

Is there a reason to, though?
The current implementation is fully conforming to the spec, and with getFieldValue not promising any normalization in the (missing) API documentation, the implementation also does not contradict the documentation.

In any case, here's a relevant RFC page.

Member

Maks3w commented Jan 3, 2014

@denis-sokolov this header is case insensitive so the correct way to deal with a mix of lower and upper cases is to have all in the same way.

PD: The RFC of your link is not related since is for MIME and not HTTP.

Contributor

god107 commented Jan 8, 2014

Hello! Can anyone check that my fix is valid and say if i can send pull request?
https://github.com/god107/zf2/commit/1ab412bfd012111fcf9a5414ebfcb8b20b32237a

Contributor

denis-sokolov commented Jan 8, 2014

@god107, you should definitely remove the @todo line in the same commit.
Other than that, looks good.

Contributor

god107 commented Jan 8, 2014

Contributor

god107 commented Jan 8, 2014

Now it should be done right.

@Maks3w Maks3w added this to the 2.3.0 milestone Feb 23, 2014

@Maks3w Maks3w closed this Feb 23, 2014

gianarb pushed a commit to zendframework/zend-http that referenced this issue May 15, 2015

gianarb pushed a commit to zendframework/zend-view that referenced this issue May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment