ZF2-268 Issue tracker "Amazon S3 broken" #1173

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

Issues betwen S3::_makeRequest and Http client

Issue tracker "Amazon S3 broken"

http://framework.zend.com/issues/browse/ZF2-268

Change-Id: I5de63da7a7f87ad169a100f2264fa561fb9f636e

Duccio Gasparri added some commits May 9, 2012

Duccio Gasparri Fixed Service/Amazon/S3/S3::_makeRequest issues with Http Client
Issue tracker "Amazon S3 broken"

http://framework.zend.com/issues/browse/ZF2-268

Change-Id: I5de63da7a7f87ad169a100f2264fa561fb9f636e
f1c9482
Duccio Gasparri S3::_makeRequest - fixed issue with Http client setParameterGet(array)
Update to pull #1173 and issue
http://framework.zend.com/issues/browse/ZF2-268

Change-Id: I8277e8247a6ce12bdc8f67b93961929a2dc76d49
62ec554

@Maks3w Maks3w commented on the diff May 9, 2012

library/Zend/Service/Amazon/S3/S3.php
if (is_array($params)) {
- foreach ($params as $name=>$value) {
- $client->setParameterGet($name, $value);
- }
+ $client->setParameterGet($params);
@Maks3w

Maks3w May 9, 2012

Member

Check the indentation in this line, you must use 4 spaces.

@dgasparri dgasparri pushed a commit to dgasparri/zf2-testserver that referenced this pull request May 10, 2012

Duccio Gasparri [ZF2-268] AmazonS3 service broken and other problems between
Service\Amazon\S3\S3 and Http\Client

http://framework.zend.com/issues/browse/ZF2-268


* substituted the $client->send()
* added appropriate ['Content-Type'] header
* fixed the call to the addSignature method
* substituted in the whole file the removed Request::getStatus() with
the new Request::getStatusCode()
* replaced in the whole file the removed Request::getHeader() method
with the Request->headers()->get()
* changed the static call to addSignature() into $this->addSignature(),
and changed its return value

This commit completely replaces pull #1173
zendframework#1173

Change-Id: Ib576245d3ee0295dc24fca6bcd77f3737dd9354b
3e2bf5b

I don't know how to "delete" this pull request, but please reject it as this commit is completely replaced by pull-request #1194.

zendframework#1194

After a couple of days of testing (and a couple of days of fighting with GitHub), I made quite a few changes and now it seems to work. I made pull request #1194 with encloses this one and added other important changes.

dgasparri closed this May 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment