[Tests] Enable more tests #1220

Merged
merged 6 commits into from May 18, 2012

Conversation

Projects
None yet
3 participants
@Maks3w
Member

Maks3w commented May 13, 2012

Another round for enable tests, this time some tests markedAsIncomplete has been reviewed.

Build Status

@@ -628,10 +628,10 @@ public function performHttpRequest($method, $url, $headers = null,
// Set the params for the new request to be performed
$this->_httpClient->setHeaders($headers);
- $urlObj = Uri\UriFactory::factory($url);

This comment has been minimized.

@akrabat

akrabat May 15, 2012

Member

Why $url here when you renamed to $uri in prepareRequest() ?

@akrabat

akrabat May 15, 2012

Member

Why $url here when you renamed to $uri in prepareRequest() ?

This comment has been minimized.

@Maks3w

Maks3w May 15, 2012

Member

renamed

@Maks3w

Maks3w May 15, 2012

Member

renamed

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat May 15, 2012

Member

As a general rule, one PR per component for stuff like this would make it easier to review and merge.

Member

akrabat commented May 15, 2012

As a general rule, one PR per component for stuff like this would make it easier to review and merge.

[Http] Enable Http tests & Fix PHP 5.4 issue
Headers with multiple values are now rendered splitting the values with commas ','

weierophinney added a commit that referenced this pull request May 18, 2012

[#1220] Add curl opts to adapter
- Added CURLOPT_INFILESIZE to adapter config to fix error in tests

@weierophinney weierophinney merged commit 5212e48 into zendframework:master May 18, 2012

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

[zendframework/zendframework#1220] Add curl opts to adapter
- Added CURLOPT_INFILESIZE to adapter config to fix error in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment