Handle return of config object from $this->config['helper_map'] in ViewManager #1333

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@superdweebie
Contributor

superdweebie commented May 22, 2012

There was a warning when config object, rather than array was returned.

@superdweebie

This comment has been minimized.

Show comment
Hide comment
@superdweebie

superdweebie May 22, 2012

Contributor

Probably not needed if 46fd68b is merged.

Contributor

superdweebie commented May 22, 2012

Probably not needed if 46fd68b is merged.

@akrabat

This comment has been minimized.

Show comment
Hide comment
@akrabat

akrabat May 23, 2012

Member

Better to test for Traversable. I didn't spot this PR until I'd created zendframework#1333. Though, as noted, both are moot if PR 1331 is merged.

Member

akrabat commented May 23, 2012

Better to test for Traversable. I didn't spot this PR until I'd created zendframework#1333. Though, as noted, both are moot if PR 1331 is merged.

@akrabat akrabat closed this May 23, 2012

@superdweebie

This comment has been minimized.

Show comment
Hide comment
@superdweebie

superdweebie May 23, 2012

Contributor

Hey @akrabat, your solution is much better. Thanks. (That's one thing I enjoy about contributing to OS projects, my coding style keeps getting sharpened.)

Contributor

superdweebie commented May 23, 2012

Hey @akrabat, your solution is much better. Thanks. (That's one thing I enjoy about contributing to OS projects, my coding style keeps getting sharpened.)

@EvanDotPro

This comment has been minimized.

Show comment
Hide comment
@EvanDotPro

EvanDotPro May 23, 2012

Member

Just for the sake of record keeping, PR 1331 has been merged to resolve this issue.

Member

EvanDotPro commented May 23, 2012

Just for the sake of record keeping, PR 1331 has been merged to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment