Fix merging of identifiers for Zend\EventManager #1955

Merged
merged 3 commits into from Jul 23, 2012

Conversation

Projects
None yet
3 participants
Contributor

juriansluiman commented Jul 23, 2012

The + operator does not work in this context of strings, because the new array has a key of 0. The + operator therefore does not merge the array($stringValue) with the original identifiers.

Tests are created, code is modified to pass the tests again.

Jurian Sluiman added some commits Jul 23, 2012

Jurian Sluiman Create tests to address bug in adding identifiers
When new identifiers are added, some get lost and are not appended
to the list of identifiers.
4bcf106
Jurian Sluiman Update test to purely address adding strings d999300
Jurian Sluiman Fix event manager to allow strings added as identifier c33ee80

This pull request fails (merged c33ee80 into 8d498ef).

juriansluiman reopened this Jul 23, 2012

This pull request fails (merged c33ee80 into 8d498ef).

juriansluiman reopened this Jul 23, 2012

Contributor

juriansluiman commented Jul 23, 2012

I stop opening/closing this PR. Locally I tested the tests from Zend\EventManager (and they pass), but tests from Zend\Form, Zend\Captcha, Zend\Barcode all fail due to some missing services. I think the recent changes to move services to their own repo caused these errors.

If I need to rebase my PR later when master is fixed, I'll do.

This pull request fails (merged c33ee80 into 8d498ef).

@weierophinney weierophinney merged commit c33ee80 into zendframework:master Jul 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment