[2.1] Added a ChromePhp logger #2080

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

waltertamboer commented Aug 1, 2012

This is basically a copy of FirePhp but than referencing the external class called ChromePhp taken from http://www.chromephp.com/

This pull request passes (merged 1c846c52 into f30ec3f).

Member

Maks3w commented Aug 1, 2012

Please add tests

Member

Maks3w commented Aug 1, 2012

And an entry in the README mentioning this new capability

This pull request fails (merged 73b481be into f30ec3f).

This pull request fails (merged bfafb2e1 into f30ec3f).

@Maks3w Maks3w closed this Aug 5, 2012

@Maks3w Maks3w reopened this Aug 5, 2012

This pull request fails (merged bfafb2e1 into f30ec3f).

Member

Maks3w commented Aug 6, 2012

Hi,

We have renamed the folder for tests from Zend to ZendTest.

Can you rebase your PR to catch this change?

Thanks in advance.

This pull request fails (merged 2221468 into fa03b37).

Contributor

b-durand commented Aug 25, 2012

Maybe we can have a WIldfireFormatter, because FirePhpFormatter and ChromePhpFormatter has exactly the same code at this moment. Maybe we can have a base class for wildfire, and FirePhp and ChromePhp are an adapter.

@waltertamboer can you fix the CS (trailing spaces)? And, can you fix the same problem as ZF2-454?

Contributor

b-durand commented Aug 25, 2012

We need to add ChromePhp like an optional dependency for composer.

Contributor

waltertamboer commented Aug 27, 2012

@b-durand We could create an "EmptyFormatter" that is the same as the old SimpleFormatter. It could just pass the message.

I don't know if this is an actual problem though. Yes it cleans up the code base a bit but it's not like you can't follow what's going on right now. Either way I'm fine with any decision, @weierophinney probably knows the right thing to do :)

Contributor

b-durand commented Aug 27, 2012

@waltertamboer What do you mean bu the old SimpleFormatter? I don't understand your EmptyFormatter... I talk about FirePhpFormatter.

Maybe you could look PR 2239: the current SimpleFormatter can display only the message. The beginning of my thinking is just that we have two identical Formatters (FirePhp and ChromePhp).

Contributor

waltertamboer commented Aug 29, 2012

@b-durand I meant the SimpleFormatter class that we first had, that was simly a class that forwarded the message, now it also has stuff in it for date and times.

weierophinney added a commit that referenced this pull request Sep 14, 2012

weierophinney added a commit that referenced this pull request Sep 14, 2012

[#2080] CS fixes
- Trailing whitespace

weierophinney added a commit to zendframework/zend-log that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-log that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-log that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment