[#ZF2-498] added Translator to Form View Helpers #2270

Merged
merged 4 commits into from Aug 30, 2012

Projects

None yet

4 participants

@robertboloc
Contributor

allows the translation of the value and placeholder attributes. It can be configured for more attributes.

@travisbot

This pull request fails (merged 6e34a71 into 89eaf41).

@robertboloc robertboloc removed the value attribute from the translatable array as sometimes …
…it is already translated by the time it reaches this part of code
78296a2
@travisbot

This pull request fails (merged 78296a2 into 89eaf41).

@travisbot

This pull request fails (merged e18a706 into 89eaf41).

@robertboloc
Contributor

This pull request fails because of an error of the travis app

Error: #<NativeException: org.virtualbox_4_1.VBoxException: The function "powerDown" returned an error condition: "The virtual machine is being powered down"  (0x80bb0002)>
@cgmartin
Contributor

Nice!

We could also simplify the FormSubmit and FormReset helpers...removing their overridden render() method...by using this new $translatableAttributes property - adding 'value' for those helpers.

@robertboloc robertboloc removed the overriden render() methods of FormSubmit and FormReset he…
…lpers and used the translatableAttributes array with value=true
cef84e7
@travisbot

This pull request fails (merged cef84e7 into 89eaf41).

@robertboloc
Contributor

@cgmartin you are right, thanks! I removed the methods and pushed the changes (seem like Travis is still down...)

@weierophinney weierophinney added a commit that referenced this pull request Aug 30, 2012
@weierophinney weierophinney [#2270][ZF2-489] CS fixes
- Trailing whitespace
d71194d
@weierophinney weierophinney added a commit that referenced this pull request Aug 30, 2012
@weierophinney weierophinney [#2270][ZF2-498] Updated README
- Noted translation capabilities of attributes
726f629
@weierophinney weierophinney merged commit cef84e7 into zendframework:master Aug 30, 2012
@weierophinney
Member

Merged to 2.0.1 and master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment