Zend\Form Added extra unit tests and some code improvements #2361

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@kpieters
Contributor

kpieters commented Sep 14, 2012

  • Fixed FormCollection::shouldWrap function
  • Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181
  • Moved check for name to static getName FormMultiCheckbox::render
  • Improved readability Zend\Form\Form::setValidationGroup
Koen Pieters
Zend\Form Added extra unit tests and some code improvements
- Fixed FormCollection::shouldWrap function
- Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181
- Moved check for name to static getName FormMultiCheckbox::render
- Improved readability Zend\Form\Form::setValidationGroup
@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Sep 14, 2012

Member

Please rebase this off of the release branch, and re-submit against that branch. A number of items are already fixed in current release and master branches, and, as such, this introduces conflicts.

Thanks!

Member

weierophinney commented Sep 14, 2012

Please rebase this off of the release branch, and re-submit against that branch. A number of items are already fixed in current release and master branches, and, as such, this introduces conflicts.

Thanks!

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Sep 18, 2012

Member

Sorry -- right after I wrote that last comment, we renamed the branches. Rebase off of master. :)

I'm going to attempt this now, to see how difficult it is.

Member

weierophinney commented Sep 18, 2012

Sorry -- right after I wrote that last comment, we renamed the branches. Rebase off of master. :)

I'm going to attempt this now, to see how difficult it is.

weierophinney added a commit that referenced this pull request Sep 18, 2012

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Sep 18, 2012

Member

Merged to master and develop -- thanks!

Member

weierophinney commented Sep 18, 2012

Merged to master and develop -- thanks!

@ghost ghost assigned weierophinney Sep 18, 2012

@kpieters

This comment has been minimized.

Show comment
Hide comment
@kpieters

kpieters Sep 18, 2012

Contributor

Nice!

Contributor

kpieters commented Sep 18, 2012

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment