Hotfix/tablegateway event feature #2688

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

Member

This supersedes: #2363

This pull-request fixes the EventFeature to work better with various EventManager workflows, it also adds a unit test for this feature.

For more discussion see #2363

ralphschindler added some commits Oct 2, 2012
@ralphschindler ralphschindler Zend\Db\TableGateway:
* Updated EventFeature to optionally take a EventManager
* Added identifiers support to the EventFeature
* Updated TableGatewayEvent to not prefix the event name with the identifier
97449d0
@ralphschindler ralphschindler Zend\Db\TableGateway
* Added unit test for EventFeature
989984d
@weierophinney weierophinney commented on the diff Oct 8, 2012
library/Zend/Db/TableGateway/Feature/EventFeature.php
$this->event = ($tableGatewayEvent) ?: new EventFeature\TableGatewayEvent();
}
+ public function getEventManager()
weierophinney
weierophinney Oct 8, 2012 Owner

Let's at least implement EventsCapableInterface, as it only defines this method.

@weierophinney weierophinney added a commit that referenced this pull request Oct 8, 2012
@weierophinney weierophinney [#2688] CS fixes
- explicitly implement EventsCapableInterface (already implemented by
  defining getEventManager())
- docblocks for all methods in EventFeature
- class and file docblocks for EventFeatureTest
0f6e254
@weierophinney weierophinney added a commit that referenced this pull request Oct 8, 2012
@weierophinney weierophinney Merge branch 'hotfix/2688' into develop
Forward port #2688
59fcb3a
@weierophinney weierophinney was assigned Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment