Fixes #2745 (generate proper query strings). #2774

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@demonkoryu
Contributor

This fixes #2745 (generate proper query strings when arg_separator.output is set to e.g. &).

@demonkoryu
Contributor

That build failure is not my fault...

@weierophinney
Member

I think a better approach would be to allow specifying the character to use for the arg separator. Right now, the issue you're addressing is specific to your implementation -- and that may be true for other users. Some might use ";" or "+" for argument separation, and this change would not help them in the least.

Would you be interested in helping make that happen? It'd be an additional option to pass to the client, and we'd read that option and use it in this location. If the option is not provided, we'd default to the php.ini setting.

@demonkoryu
Contributor

Will do. I'll post another PR tomorrow.
Config option argseparator, perhaps?

@weierophinney
Member

@demonkoryu You can push the changes to the same branch, and they'll show up in this PR.

And yes -- argseparator and/or arg_separator.

@demonkoryu
Contributor
@weierophinney weierophinney was assigned Nov 9, 2012
@weierophinney weierophinney added a commit that referenced this pull request Nov 9, 2012
@weierophinney weierophinney [#2774] Provided unit tests
- Tested default argument separator
- Tested that argument separator may be provided
- Provided functional test indicating provided argument separator is
  used
7b3da41
@weierophinney weierophinney added a commit that closed this pull request Nov 9, 2012
@weierophinney weierophinney Merge branch 'feature/2774' into develop
Close #2774
Close #2745
58dde55
@weierophinney
Member

I added unit tests, and fixed an issue in the process. Merged against develop branch, as it introduces a new method into the API; will release with 2.1.

@weierophinney weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#2774] Provided unit tests
- Tested default argument separator
- Tested that argument separator may be provided
- Provided functional test indicating provided argument separator is
  used
f990979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment