Fixes #2745 (generate proper query strings). #2774

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

demonkoryu commented Oct 16, 2012

This fixes #2745 (generate proper query strings when arg_separator.output is set to e.g. &).

Contributor

demonkoryu commented Oct 16, 2012

That build failure is not my fault...

Owner

weierophinney commented Oct 30, 2012

I think a better approach would be to allow specifying the character to use for the arg separator. Right now, the issue you're addressing is specific to your implementation -- and that may be true for other users. Some might use ";" or "+" for argument separation, and this change would not help them in the least.

Would you be interested in helping make that happen? It'd be an additional option to pass to the client, and we'd read that option and use it in this location. If the option is not provided, we'd default to the php.ini setting.

Contributor

demonkoryu commented Oct 30, 2012

Will do. I'll post another PR tomorrow.
Config option argseparator, perhaps?

Owner

weierophinney commented Oct 30, 2012

@demonkoryu You can push the changes to the same branch, and they'll show up in this PR.

And yes -- argseparator and/or arg_separator.

Contributor

demonkoryu commented Oct 31, 2012

@ghost ghost assigned weierophinney Nov 9, 2012

weierophinney added a commit that referenced this pull request Nov 9, 2012

[#2774] Provided unit tests
- Tested default argument separator
- Tested that argument separator may be provided
- Provided functional test indicating provided argument separator is
  used
Owner

weierophinney commented Nov 9, 2012

I added unit tests, and fixed an issue in the process. Merged against develop branch, as it introduces a new method into the API; will release with 2.1.

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

[zendframework/zendframework#2774] Provided unit tests
- Tested default argument separator
- Tested that argument separator may be provided
- Provided functional test indicating provided argument separator is
  used

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment