Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Server] & [Soap] Typos and docblocks #2844

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Member

Maks3w commented Oct 28, 2012

Fix typos and docblocks

Add some typehint to method argument

Remove code marked as deprecated since ZF1

@weierophinney weierophinney commented on an outdated diff Oct 30, 2012

library/Zend/Server/Reflection/AbstractFunction.php
* @param null|string $namespace
* @param null|array $argv
* @throws Exception\InvalidArgumentException
* @throws Exception\RuntimeException
*/
- public function __construct(\Reflector $r, $namespace = null, $argv = array())
+ public function __construct(\ReflectionFunctionAbstract $r, $namespace = null, $argv = array())
@weierophinney

weierophinney Oct 30, 2012

Owner

Import ReflectionFunctionAbstract.

@weierophinney weierophinney commented on an outdated diff Oct 30, 2012

library/Zend/Server/Reflection/ReflectionClass.php
@@ -43,7 +43,7 @@ class ReflectionClass
/**
* ReflectionClass object
- * @var ReflectionClass
+ * @var \ReflectionClass
@weierophinney

weierophinney Oct 30, 2012

Owner

If this is used in the code anywhere, import it. If not, it's fine. :)

@weierophinney weierophinney commented on an outdated diff Oct 30, 2012

library/Zend/Soap/Server/DocumentLiteralWrapper.php
@@ -123,6 +123,7 @@ public function __call($method, $args)
protected function _parseArguments($method, $document)
{
$reflMethod = $this->reflection->getMethod($method);
+ /** @var \Zend\Server\Reflection\ReflectionParameter[] $params */
@weierophinney

weierophinney Oct 30, 2012

Owner

Can these IDE hints be done without using docblock notation? I.e., use the following:

/* @var \Zend\Server\Reflection\ReflectionParameter[] $params */

I ask, as in vim, it messes up syntax highlighting when the extra "*" is in there. If it can't that's fine; just curious.

@ghost ghost assigned weierophinney Oct 30, 2012

Owner

weierophinney commented Oct 30, 2012

Awesome -- thanks! Been on my todo list for a looooong time!

weierophinney added a commit to zendframework/zend-server that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-soap that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment