Serializer #3

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
Member

marc-mabe commented Sep 9, 2010

  • PHPSerialize -> PhpSerialize
  • fixed wrong namespace on serializer adapter loader
  • tests check exception on missing php extension

all tests of Zend/Serializer passed

Owner

weierophinney commented Sep 20, 2010

Merged into zf2 master -- thanks!

@ezimuel ezimuel referenced this pull request in ezimuel/zf2 Dec 14, 2011

@marc-mabe marc-mabe Merge pull request #3 from prolic/cache
Zend\Cache
dabe8e9

@ezimuel ezimuel referenced this pull request in ezimuel/zf2 Mar 2, 2012

@weierophinney weierophinney [#3] ResultSet tests and bugfixes
- Tested Zend\Db\ResultSet\ResultSet, and fixed several logic errors, as
  well as completed implementation
5bde54c

@ezimuel ezimuel added a commit that referenced this pull request May 18, 2012

@ezimuel ezimuel Merge pull request #3 from Maks3w/ezimuel/feature/crypt
Ezimuel/feature/crypt
cd92ad5

@padraic padraic added a commit that referenced this pull request Jul 5, 2012

@padraic padraic Merge pull request #3 from adamlundrigan/feature/zend-form-with-escaper
Feature: Use new escape view helpers in Zend\Form\View\Helper
c66d994

This was referenced Aug 9, 2012

@ezimuel ezimuel added a commit to zendframework/zend-math that referenced this pull request May 15, 2015

@ezimuel ezimuel Merge pull request zendframework/zendframework#3 from Maks3w/ezimuel/…
…feature/crypt

Ezimuel/feature/crypt
e0ee5c9

@ezimuel ezimuel added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015

@ezimuel ezimuel Merge pull request zendframework/zendframework#3 from Maks3w/ezimuel/…
…feature/crypt

Ezimuel/feature/crypt
3851bda

@gianarb gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015

@marc-mabe marc-mabe Merge pull request zendframework/zendframework#3 from prolic/cache
Zend\Cache
9683acb

@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@prolic prolic Merge pull request zendframework/zendframework#3 from Maks3w/navigati…
…on-renamed-interfaces

Thanks!
8cc86f1

@isisis isisis added a commit to isisis/zf2 that referenced this pull request May 28, 2015

@isisis isisis Fix for AbstractNavigationFactory.php
I think it's a common use case for the default navigation, to add pages and sub pages across many modules.
There's currently an issue when adding sub pages to another page that you expect to be in configuration already.
The main page could be changed to another name, could be removed or the module could be disabled inside an application architecture that uses ZF2 modules like plug-ins.

What happens in this case?

-------------------------------------------------------------
Fatal error: Uncaught exception 'Zend\Navigation\Exception\InvalidArgumentException' with message 'Invalid argument: Unable to determine class to instantiate' in /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Page/AbstractPage.php:254 Stack trace: #0 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/AbstractContainer.php(114): Zend\Navigation\Page\AbstractPage::factory(Array) #1 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/AbstractContainer.php(165): Zend\Navigation\AbstractContainer->addPage(Array) #2 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Navigation.php(35): Zend\Navigation\AbstractContainer->addPages(Array) #3 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Service/AbstractNavigationFactory.php(38): Zend\Navigation\Navigation->__construct(Array) #4 [internal function]: Zend\Navigation\Service\AbstractNavigationFactory->createService(Obj in /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php on line 946
-------------------------------------------------------------

This fix solves the problem, by ignoring a main page, when it's missing uri or mvc values, and could be used as quick fix.

For future I would like to see a validation for the pages configs, before they're being injected to navigation.
Another approach could be to add a separate "navigation-extension" configuration beside the "navigation" configuration. The "navigation-extension" configuration could be used to extend the navigation safely. The NavigationFactory would then use only the configuration parts that already have a valid existing navigation entry inside "navigation" key.
c026176

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment