Hotfix for #2451 #3009

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@Ocramius
Member

Fix for #2451

@weierophinney weierophinney added a commit that referenced this pull request Nov 19, 2012
@weierophinney weierophinney Merge branch 'hotfix/3009' into develop
Forward port #3009
713491b
@weierophinney weierophinney added a commit that closed this pull request Nov 19, 2012
@weierophinney weierophinney Merge branch 'hotfix/3009'
Close #3009
Fix #2451
74be039
@WanderingZombie

if ($isRequired) is passed in as a non-null value it will be negated. I suggest using the following instead?

is_null($isRequired) ? true : !empty($isRequired),

As we all know, comparing (false==null) will always give true. (false===null) will give false as expected. To avoid the == / === coding mistake that's all too easy, using is_null() is far safer

Member

I didn't change this LOC, I'd need a test for that to do so, and I don't think it's in the scope of this PR :)

@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3009' 02a1820
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3009' into develop 4bd3bc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment