Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Response Json Client #3011

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

pkarc commented Nov 19, 2012

As http://www.json-rpc.org/wiki/specification

1.2 Response
error - An Error object if there was an error invoking the method. It must be null if there was no error.

Not always is an Error this parameter it could be null.
To be more explicit, when using json-client the response come with error as null if there is no error

@Maks3w Maks3w commented on the diff Nov 19, 2012

library/Zend/Json/Server/Response.php
* @return Response
*/
- public function setError(Error $error)
@Maks3w

Maks3w Nov 19, 2012

Member

There is no need to remove the type hint for pass a null value just make it optional

setError(Error $error = null)

@weierophinney weierophinney added a commit that referenced this pull request Nov 19, 2012

@weierophinney weierophinney [#3011] CS fixes
- trailing whitespace
56fce75

@weierophinney weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#3011] CS fixes
- trailing whitespace
9626342

@weierophinney weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/3011' into develop 8aa284d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment