fix typo 'consist of' should be 'consists of' in singular #3042

Merged
merged 1 commit into from Nov 21, 2012

Conversation

Projects
None yet
4 participants
Contributor

samsonasik commented Nov 21, 2012

No description provided.

@Maks3w Maks3w merged commit 831879b into zendframework:master Nov 21, 2012

1 check passed

default The Travis build passed
Details

I actually think that it was correct before ("Header name must ... consist of only letters, numbers and hashes.")

Contributor

samsonasik replied Nov 22, 2012

I might be wrong as I'm not a native Englisch speaker, but "must" is an auxiliary verb and "consist" must therefore be infinitve.

Contributor

samsonasik commented Nov 24, 2012

make sense. but PR is already closed. i think you should create a new PR :)

Both are correct, but the meaning changes.

If the 'must' should be applied to all parts of the sentence, it should have stayed as it was! If only the first part (starting with a letter) is a MUST and the rest is not, then the correction was in order. Since I understand that all parts are subject to 'must', this change has to be reverted.

I think you should change it back yourself, @samsonasik , since you wrongly corrected it.

Contributor

samsonasik commented Nov 25, 2012

@Damu112 @markushausammann : ok, changed it back :) in #3061

@weierophinney weierophinney pushed a commit to zendframework/zend-mail that referenced this pull request May 14, 2015

@Maks3w Maks3w Merge pull request zendframework/zendframework#3042 branch 'hotfix/typo' 7a6cebf

@weierophinney weierophinney pushed a commit to zendframework/zend-mail that referenced this pull request May 14, 2015

@Maks3w Maks3w Forward port zendframework/zendframework#3042 c208a5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment