Feature/cookies refactor #3079

Closed
wants to merge 682 commits into
from

Projects

None yet
@jcrawford

Work related to
#2572 - Zend\Http\Client\CookieJar is broken
#3044 - Extending Zend\Mvc\Router\Http\Segment causes error

guice and others added some commits Oct 22, 2012
@guice guice Added the ability for FirePhp to understand 'extras' passed to \Zend\Log 6b6cb04
@bakura10 bakura10 Resolve conflicts 50319d4
gabbert_p Moved the line/label logic into the formatter. 72df869
gabbert_p Added unit tests for new FirePhp formatter functionality. 3b8a7d7
@chrvadala chrvadala Update library/Zend/I18n/View/Helper/DateFormat.php 0054e2c
gabbert_p Removed trailing spaces. f9ef948
gabbert_p Unit test update: empty extra data should return NULL label (not just…
… empty).
10d47af
@guice guice Ran php-cs-fixer against FirePhp classes. 8b429a7
@bakura10 bakura10 Resolve conflicts 2c48be7
@DaHaiz DaHaiz Update library/Zend/Form/Element/Collection.php
If the initial target element object gets overwritten with the current one for extracting the values, the original object gets corrupted and the last one extracted stays in. This means that maybe for later hydrating a completely new object (think of the allowAdd option) the values from the last extracted one get transferred to the new one. In case of active record objects with object states (e.g. isNew) this could lead to unwanted and hard to debug errors.
So cloning the target element and work on the cloned one for extracting is the more appropriate approach imo. The original targetElements objects stays intact.
ba371b3
@DaHaiz DaHaiz Update library/Zend/Form/View/Helper/FormCollection.php
added possibility to set own helper for rendering fieldsets. Now one can use an own helper for fieldsets and for element and benefit from the FormCollection-helpers useful features. If you would solve this problem with simply extending the FormCollection Helper you would have to copy the whole render() method which is not very nice imo.
557ab5f
@ClemensSahs ClemensSahs add a view event
- add "ViewEvent::EVENT_RENDERER_POST"
e55cff0
@weierophinney weierophinney Merge branch 'hotfix/2831' into develop
Conflicts:
	CHANGELOG.md
	library/Zend/Version/Version.php
1404824
@weierophinney weierophinney Merge branch 'hotfix/2800' into develop
Conflicts:
	library/Zend/Code/Scanner/ClassScanner.php
cd9ad7c
@weierophinney weierophinney Merge branch 'hotfix/2834' into develop
Forward port #2834
3509d3b
@weierophinney weierophinney Merge branch 'hotfix/2850' into develop
Forward port #2850
61c8bb6
@Maks3w Maks3w Merge pull request #2805 branch 'hotfix/fix-docblock' 5d473f2
@weierophinney weierophinney Merge branch 'add-paginator-factory' of git://github.com/blanchonvinc…
…ent/zf2 into feature/paginator-factory

Conflicts:
	library/Zend/Mvc/Service/ServiceListenerFactory.php
f3a8a34
@weierophinney weierophinney Merge branch 'feature/paginator-factory' into develop
Close #2316
b3c40ad
@weierophinney weierophinney Merge branch 'feature/cache/xcache' of git://github.com/marc-mabe/zf2…
… into feature/xcache

Conflicts:
	tests/ZendTest/Cache/Storage/Adapter/CommonAdapterTest.php
460f6a1
@weierophinney weierophinney [#2668][#2581] Do not enable xcache tests by default 5d78275
@weierophinney weierophinney Merge branch 'feature/logger-factory' of git://github.com/stefankleff…
…/zf2 into feature/log-factory
e22c836
@weierophinney weierophinney Merge branch 'feature/log-factory' into develop
Close #2725
d717c1e
@weierophinney weierophinney Merge branch 'feature/log-processors' of git://github.com/stefankleff…
…/zf2 into feature/log-processors

Conflicts:
	library/Zend/Log/Logger.php
	tests/ZendTest/Log/LoggerTest.php
363fa15
@weierophinney weierophinney [#2727] CS review
- indentation
- trailing whitespace
- object calisthenics
8635f0a
@weierophinney weierophinney [#2727] CS review
- Trailing whitespace
- Cache generated value, as it will not change in lifetime of request
602858d
@weierophinney weierophinney Merge branch 'feature/log-processors' into develop
Close #2727
04c1d69
@weierophinney weierophinney Merge branch 'feature/route-access' of git://github.com/stefankleff/z…
…f2 into feature/route-retrieval
106fc16
@weierophinney weierophinney Merge branch 'feature/route-retrieval' into develop
Close #2783
Fixes #2495
5e9686a
@weierophinney weierophinney Merge branch 'hotfix/2790' into develop
Forward port #2790
083d46f
@Maks3w Maks3w Merge branch 'hotfix/zend-soap-fault' into develop 742eaee
@weierophinney weierophinney Merge branch 'hotfix/2791' into develop
Forward port #2791
5583441
@weierophinney weierophinney Merge branch 'hotfix/2793' into develop
Forward port #2793
db82cf7
@weierophinney weierophinney Merge branch 'code' of git://github.com/prolic/zf2 into feature/token…
…-scanner-namespaces

Conflicts:
	library/Zend/Code/Scanner/TokenArrayScanner.php
f3d4c4e
@weierophinney weierophinney Merge branch 'feature/token-scanner-namespaces' into develop
Close #2801
9a13404
@weierophinney weierophinney Merge branch 'hotfix/2803' into develop
Forward port #2803
8f64ecb
@weierophinney weierophinney Merge branch 'hotfix/2808' into develop
Forward port #2808
d796e29
@weierophinney weierophinney Merge branch 'hotfix/2810' into develop
Forward port #2810
b78049c
@weierophinney weierophinney Merge branch 'hotfix/2813' into develop
Forward port #2813
3ae4a85
@weierophinney weierophinney Merge branch 'hotfix/2814' into develop
Forward port #2814
bf8ce2b
@Maks3w Maks3w [Server] & [Soap] Typos and docblocks 98a15ee
@Maks3w Maks3w [Server] Remove code specific for PHP 5.1 175bdbb
@weierophinney weierophinney Merge branch 'firephp-understand-extras' of git://github.com/guice/zf…
…2 into feature/log-firephp-extra
4d1f7dc
@weierophinney weierophinney Merge branch 'feature/log-firephp-extra' into develop
Close #2822
7e3e120
@Maks3w Maks3w Merge pull request #2830 branch 'hotfix/url-in-query' 7176825
@weierophinney weierophinney Merge branch 'hotfix/2835' into develop
Forward port #2835
6144a6d
@Maks3w Maks3w Merge branch 'hotfix/remove-unused-use-statements' into develop
Conflicts:
	library/Zend/Log/Formatter/Simple.php
815456e
@Maks3w Maks3w Merge pull request #2847 branch 'hotfix/typo' 072ae85
@weierophinney weierophinney Merge branch 'hotfix/2843' into develop
Forward port #2843
fa35c5f
@Maks3w Maks3w Merge branch 'master' into develop 41bdad8
@Maks3w Maks3w Merge pull request #2851 branch 'hotfix/add-blank-decorator-as-invoka…
…ble'
6ea932c
@weierophinney weierophinney Merge branch 'hotfix/2854' into develop
Forward port #2854
8dd848e
@Maks3w Maks3w Review Feedback 8caa45d
@weierophinney weierophinney Merge branch 'hotfix/2858' into develop
Forward port #2858
66519e1
@weierophinney weierophinney Merge branch 'hotfix/typos' of git://github.com/Maks3w/zf2 into featu…
…re/server-reflection
b1639e5
@weierophinney weierophinney Merge branch 'feature/server-reflection' into develop
Close #2844
af1a19b
@bakura10 bakura10 Conflict ecc92ed
@bakura10 bakura10 Clean history f375fd8
@bakura10 bakura10 Hook outside interface to avoid BC 225e1ae
@cgmartin cgmartin WIP on File Upload refactor efb051e
@cgmartin cgmartin Simplify File element for review 1af218e
@cgmartin cgmartin Form fix #2586 until it can be merged 02f8f7a
@cgmartin cgmartin File Validators refactored 3f85f5f
@cgmartin cgmartin File validator tests fixed 1b99ce5
@cgmartin cgmartin New File Filter RenameUpload for securely moving uploaded files a68d5b2
@cgmartin cgmartin Refactored Zend/File/Transfer/Adapter/Http upload progress methods in…
…to Zend/Progressbar/Upload/UploadHandlers
81d634b
@cgmartin cgmartin New Form Elements for File Upload Progress tracking 7aaee69
@cgmartin cgmartin Unit tests for new Zend/Form/Element/File elements 4108486
@cgmartin cgmartin Unit test coverage for InputFilter, File Element, and FormFile view h…
…elper changes
69e762a
@cgmartin cgmartin Unit test for AbstractUploadHandler 4532931
@cgmartin cgmartin Removed Zend/File/Transfer and tests 420b811
@cgmartin cgmartin Fix for HTML5 multiple attribute on file element e9ac49d
@cgmartin cgmartin Added bullet points to Changelog for File Upload rewrite 2b297ca
@Maks3w Maks3w [Code] Add support for @throws, multiple types and typed arrays d166256
@DaHaiz DaHaiz fix cs in FormCollection-helper 9fd60cb
@DaHaiz DaHaiz added test for custom fieldset helper use in formcollection helper 14cc70a
@demonkoryu demonkoryu Fixes #2745. 5821567
@weierophinney weierophinney Merge branch 'hotfix/2867' into develop
Forward port #2867
58c01dd
Bruno CHALOPIN Adding hasUnknown and getUnknown methods to detect and get unknown in…
…puts
04fb242
@Maks3w Maks3w Merge pull request #2873 branch 'hotfix/add-missing-throws-tags' 191e21b
@Maks3w Maks3w Merge pull request #2871 branch 'hotfix/change-logical-operator' 60401a2
@marc-mabe marc-mabe Memcached:
 - fixed some small issues on sharing memcached resources over different instances of Zend\Cache\Storage\Adapter\Memcached
   - implemented namespace support manually to not change Memcached::OPT_PREFIX_KEY on a memcached resource
   - added Zend\Cache\Storage\Adapter\MemcachedResourceManager that handles memcached resources
 - removed the default server configuration (127.0.0.1:11211)
 - added an option to create persistent connections "persistent_id"
482014a
@Maks3w Maks3w [Server] Reuse code from Zend\Code
Also remove underscore preffix from methods name
6132530
@marc-mabe marc-mabe removed not needed use statement 9b3c775
@marc-mabe marc-mabe fixed wrong doc-comment 5e325d4
@weierophinney weierophinney Merge branch 'feature/server-reflection' of git://github.com/Maks3w/z…
…f2 into feature/server-refactor

Conflicts:
	library/Zend/Server/Reflection/AbstractFunction.php
f75c6b6
@weierophinney weierophinney [#2868] Fix some libxml test failures
- XmlRpc needed testing as it relies on Zend\Server\Reflection. Changes
  in recent versions of PHPUnit have made it more greedy with regards to
  warnings, which led to new test failures. The changes introduced make
  the component more resilient.
28b11a7
@weierophinney weierophinney Merge branch 'feature/server-refactor' into develop
Close #2868
17c747e
@DaHaiz @DaHaiz DaHaiz fix for extract behavior in collections plus test eba8e1a
@DaHaiz @DaHaiz DaHaiz fix for extract behavior in collections plus test f710723
@DaHaiz DaHaiz resolce merge conflict c1f0d59
@DaHaiz @DaHaiz DaHaiz removed debug code in test 92031cd
@chrvadala chrvadala Change-Id: Ifc71c8b7737c5d0bda9fd59d8811ca379f1d7799 c814c36
@cgmartin cgmartin New FilePostRedirectGet plugin; Refactored PostRedirectGet plugin 2849b99
@ezimuel ezimuel Performance improvement Hmac e53c709
@ezimuel ezimuel Merge branch 'hotfix/optimize-pbkdf2' into develop 44f2354
@ezimuel ezimuel Fixed Hmac test 8572733
@weierophinney weierophinney Merge branch 'hotfix/2889' into develop
Forward port #2889
3f7b6a0
@cgmartin cgmartin Rewrite of FilePostRedirectGet plugin to use consistent return values…
… to match PostRedirectGet plugin
35cec8b
@jmikola jmikola Revise MongoDB session save handler's gc() docs dcfe127
Maks3w and others added some commits Nov 14, 2012
@Maks3w Maks3w Forward port #2940 55c7cba
@Maks3w Maks3w Forward port #2921 14fbade
@Maks3w Maks3w Forward port #2905 abe22b8
@Maks3w Maks3w Forward port #2904 a07bdd9
@Maks3w Maks3w Forward port #2901 835da90
@Maks3w Maks3w Forward port #2893 be2556f
@Maks3w Maks3w Merge pull request #2892 from jmikola/patch-2
Revise MongoDB session save handler's gc() docs
79a77f3
@Maks3w Maks3w Forward port #2877 a5632a4
@akrabat akrabat Merge branch 'hotfix/2670' into develop
Forward port #2670
8943900
@Maks3w Maks3w Merge pull request #2975 branch 'hotfix/adapt-classmapautoload-to-int…
…erface-constraint'
6f9402d
@Maks3w Maks3w Forward #2983 22df1aa
@Maks3w Maks3w Forward #2974 ca0f970
Maximilian Walter Zend\Mime\Part::getEncodedStream() did not use correct EOL (Issue #2918) c3bb7fd
@Slamdunk Slamdunk Decoupled Zend\Db\Sql from concrete Adapters c518cc2
@Slamdunk Slamdunk Decoupled from Adapter the main Sql factory 389fd10
@marc-mabe marc-mabe Added note of new xcache storage adapter 7fa9175
@Maks3w Maks3w Merge pull request #2990 from marc-mabe/news/xcache
Added note of new xcache storage adapter
fb88bd5
@Maks3w Maks3w Merge pull request #2985 from maximilian-walter/develop
Zend\Mime\Part::getEncodedStream() did not use correct EOL (Issue #2918)
38e6d95
@weierophinney weierophinney Merge branch 'feature/dbsql-interfaces' of git://github.com/Slamdunk/…
…zf2 into hotfix/2989

Conflicts:
	library/Zend/Db/Sql/AbstractSql.php
	library/Zend/Db/Sql/Select.php
8571347
@weierophinney weierophinney Merge branch 'hotfix/2989' into develop
Close #2989
c1972c9
@weierophinney weierophinney Merge branch 'hotfix/2932' into develop
Forward port #2932
ce33449
@weierophinney weierophinney Merge branch 'feature/share-memcached' of git://github.com/marc-mabe/…
…zf2 into feature/memcached-improvements
5223e36
@weierophinney weierophinney Merge branch 'feature/memcached-improvements' into develop
Close #2876
8099772
@weierophinney weierophinney Merge branch 'hotfix/2878' into develop
Conflicts:
	library/Zend/File/Transfer/Adapter/AbstractAdapter.php
	library/Zend/File/Transfer/Adapter/Http.php
	tests/ZendTest/Log/Writer/AbstractTest.php
	tests/ZendTest/Log/Writer/DbTest.php
500c284
@weierophinney weierophinney Merge branch 'hotfix/2879' into develop
Forward port #2879
748468e
@weierophinney weierophinney Merge branch 'hotfix/2907' into develop
Forward port #2907
c45da93
@weierophinney weierophinney Merge branch 'hotfix/2909' into develop
Forward port #2909
c39cf61
@Maks3w Maks3w Forward port #2994 2428736
@Maks3w Maks3w Forward port #2997 7af2761
@pkarc pkarc Update library/Zend/Json/Server/Response.php 14a423e
@pkarc pkarc Update tests/ZendTest/Json/Server/ResponseTest.php cc54e92
Martin Meredith Add a bunch of traits to ZF2
As requested @

protecinnovations/zf2-traits#1

This is the initial commit to start getting traits into ZF2.

We need to move our tests over - which are currently using Mockery.
331151c
@alexdenvir alexdenvir Improve coding standards on new traits, add tests c568239
Martin Meredith Fix Minor problems with tests b0e0b89
@pkarc pkarc Update library/Zend/Json/Server/Response.php 022fa4c
@alexdenvir alexdenvir Improve function comment quality, clean up tests a little 8add698
@weierophinney weierophinney Merge branch 'hotfix/2924' into develop
Forward port #2924
8eeb1fc
@weierophinney weierophinney Merge branch 'hotfix/2930' into develop
Forward port #2930
247ec78
@weierophinney weierophinney Merge branch 'hotfix/2937' into develop
Forward port #2937
ddb431a
@cgmartin cgmartin PRG Plugin fixes: Incorrect use of session hops expiration 44cfeae
@weierophinney weierophinney Merge branch 'form/date-time-select' of git://github.com/bakura10/zf2…
… into feature/2947
aa7b1c7
@weierophinney weierophinney [#2947] Alias DateTime to PhpDateTime
- because we have a DateTime class in the current namespace
025968b
@weierophinney weierophinney [#2947] CS fixes
- eof character
313f94f
@weierophinney weierophinney Merge branch 'feature/2947' into develop
Close #2947
bc798fa
@weierophinney weierophinney Merge branch 'hotfix/2951' into develop
Forward port #2951
41c3fbe
@weierophinney weierophinney Merge branch 'hotfix/2952' into develop
Forward port #2952
8e354e9
weierophinney and others added some commits Nov 19, 2012
@weierophinney weierophinney Merge branch 'hotfix/2957' into develop
Forward port #2957
2e7d402
@weierophinney weierophinney Merge branch 'hotfix/2976' into develop
Forward port #2976
a4a69e6
@weierophinney weierophinney Merge branch 'hotfix/2981' into develop
Forward port #2981
0dcd8df
@weierophinney weierophinney Merge branch 'hotfix/2986' into develop
Conflicts:
	library/Zend/Code/Scanner/PropertyScanner.php
9670eb0
@weierophinney weierophinney Merge branch 'hotfix/2987' into develop
Forward port #2987
577c6c5
@weierophinney weierophinney Merge branch 'hotfix/3002' into develop
Forward port #3002
bf15465
@weierophinney weierophinney Merge branch 'hotfix/3003' into develop
Forward port #3003
ec46781
@weierophinney weierophinney Merge branch 'hotfix/3006' into develop
Forward port #3006
7d0c5e9
@weierophinney weierophinney Merge branch 'hotfix/3008' into develop
Forward port #3008
cb5a3b4
@weierophinney weierophinney Merge branch 'hotfix/3009' into develop
Forward port #3009
713491b
@weierophinney weierophinney Merge branch 'develop' of git://github.com/pkarc/zf2 into hotfix/3011 bbda405
@weierophinney weierophinney [#3011] CS fixes
- trailing whitespace
56fce75
@weierophinney weierophinney Merge branch 'hotfix/3011' into develop
Close #3011
19a1bac
@weierophinney weierophinney Merge branch 'fix/prg-plugins' of git://github.com/cgmartin/zf2 into …
…hotfix/3016
91b6850
@weierophinney weierophinney Merge branch 'hotfix/3016' into develop
Close #3016
aee25b5
@weierophinney weierophinney Merge branch 'hotfix/3013' into develop
Forward port #3013
f671feb
@weierophinney weierophinney Check that service locator exists
- before attempting to pull something from it
213381c
@weierophinney weierophinney Fix CS issues
- EOF endings
9c4c04c
@weierophinney weierophinney Merge branch 'hotfix/service-locator-existence' into develop
Fix failing tests and CS issues on develop branch
7c4f2f9
@cgmartin cgmartin PRG Plugins fix - Lost data if expiration hops set after data is set 52c0ff1
@alexdenvir alexdenvir Remove SharedEventManagerAwareTrait and ServiceManagerAwareTrait, and…
… associated tests
2ffed1f
@alexdenvir alexdenvir Make EventManagerAwareTrait use ProvidesEvents 0cf7a33
@weierophinney weierophinney Merge branch 'feature/traits' of git://github.com/protecinnovations/z…
…f2 into feature/2927
eb4cd51
@weierophinney weierophinney Merge branch 'feature/2927' into develop
Close #2927
df78993
@weierophinney weierophinney Merge branch 'fix/prg-plugins' of git://github.com/cgmartin/zf2 into …
…hotfix/3019
fb1cbbf
@weierophinney weierophinney CS fixes
- EOF, indentation, and trailing whitespace
- Unrelated to original issue, but will ensure develop branch passes tests now
2e79421
@weierophinney weierophinney Merge branch 'hotfix/3019' into develop
Close #3019
174d505
@weierophinney weierophinney Merge branch 'hotfix/3027' into develop
Forward port #3027
fd98312
@weierophinney weierophinney Merge branch 'hotfix/3029' into develop
Forward port #3029
8347c5e
@weierophinney weierophinney Merge branch 'hotfix/3025' into develop
Forward port #3025
10ad838
@ezimuel ezimuel Merge branch 'weierophinney-hotfix/2821-loadmodule' into develop 3ad8a5a
@ralphschindler ralphschindler Merge branch 'voxel01-fixissue2896' into develop 54fef9e
@ralphschindler ralphschindler Merge branch 'stormwild-hotfix/3001' into develop f1d5c4b
@weierophinney weierophinney Merge branch 'hotfix/3031' into develop
Forward port #3031
3c65424
@weierophinney weierophinney Merge branch 'release/2.0.4' into develop
Conflicts:
	CHANGELOG.md
	README.md
	library/Zend/Version/Version.php
6191c68
@weierophinney weierophinney Merge branch 'hotfix/cache-composer' into develop
Fix composer.json issue
37e023e
@Maks3w Maks3w Forward port #3039 f4171e2
@Maks3w Maks3w Forward port #3048 fd412cf
@Maks3w Maks3w Forward port #3042 3c1f321
@weierophinney weierophinney Merge branch 'hotfix/3045' into develop
Forward port #3045
791cb40
Joseph Crawford Working on the HTTP Client and Persistant Cookies 4386275
Joseph Crawford Working on the HTTP Client and Persistant Cookies 2c58012
Joseph Crawford Working on the Http Client, making persistant cookies work 3f6e54d
Joseph Crawford Removing invalid indentation and trailing whitespace a8ce3d3
Joseph Crawford Removing invalid indentation and trailing whitespace second attempt bcf2119
Joseph Crawford Removing invalid indentation and trailing whitespace third attempt 8aead6a
Joseph Crawford Making Client::addCookie actually support taking a single Header\SetC…
…ookie object
b60599c
Joseph Crawford fixing indentation a90e78c
Joseph Crawford fixing issue 3044: changing visibility of from private to protected. be85698
Joseph Crawford Fixing issue 2662: Adding removeHeaders method to Http/Headers for ea…
…sy removal of all headers in the container
fcc456f
Joseph Crawford Removing removeHeaders method as clearHeaders exists 97ada29
@jcrawford jcrawford closed this Nov 27, 2012
@taiwen
taiwen commented on 3f85f5f Feb 11, 2013

The commit broke built-in calls for validators for extension, exclueextension, etc. by removing the second argument in isValid($value, $file).

Contributor

@taiwen Thanks for reporting this, I'll take a stab at a fix.

Some background:

  • Second argument to isValid() was removed for the file validators to match ValidatorInterface.
  • Original assumption was that Zend\Transfer was to be removed when this refactor was implemented. Was added back in last minute before 2.1 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment