Basic support for aggregates in SharedEventManager according to feedback... #3084

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@stefankleff

Replaces #2819

@weierophinney weierophinney commented on the diff Dec 11, 2012
...ary/Zend/EventManager/SharedEventManagerInterface.php
@@ -67,4 +67,21 @@ public function getEvents($id);
@weierophinney
weierophinney Dec 11, 2012

Changing interfaces is a BC break.

The way to get around this is to introduce a new interface -- let's say, "SharedListenerAggregateAwareInterface" -- with the new methods. The default implementation can then implement that as well as the SharedEventManagerInterface.

(If I merge today, I'll do that work; if not, I'll let you know.)

@weierophinney weierophinney added a commit that referenced this pull request Dec 11, 2012
@weierophinney weierophinney [#3084] Split new interface methods into separate interface
- To prevent a BC break (uncovered by running the unit tests), moved new
  attachAggregate() and detachAggregate() methods into a separate interface; the
  SharedEventManager implementation now also implements this new interface.
0482078
@weierophinney
Zend Framework member

Merged, with the changes mentioned in feedback. Which, by the way, were caught by Travis -- that's what the CI failures were. :)

@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney [#3084] Split new interface methods into separate interface
- To prevent a BC break (uncovered by running the unit tests), moved new
  attachAggregate() and detachAggregate() methods into a separate interface; the
  SharedEventManager implementation now also implements this new interface.
a181500
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'feature/events-shared-aggregates' into develop
Close #3084
67cd670
@weierophinney weierophinney added a commit to zendframework/zend-eventmanager that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#3084] Split new interface methods into s…
…eparate interface

- To prevent a BC break (uncovered by running the unit tests), moved new
  attachAggregate() and detachAggregate() methods into a separate interface; the
  SharedEventManager implementation now also implements this new interface.
b235040
@weierophinney weierophinney added a commit to zendframework/zend-eventmanager that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'feature/events-shared-aggregates' into develop d41e72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment