Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Zend\Form\View\Helper\Captcha\AbstractWord input and hidden attributes #3144

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

stefanotorresi commented Dec 10, 2012

AbstractWord::renderCaptchaInputs() gives the same attributes to both input and hidden html tags. This may lead to the same id attribute, if set, in both tags, wich is not W3C compliant and prevents from using <label> for attribute correctly.

Since the id attribute is unlikely to be used on the hidden element, one possible solution is to pass a copy of the attributes array without the id key to renderCaptchaHidden().

Contributor

stefanotorresi commented Dec 3, 2012

i can make a pull request as soon as the issue is acknowledged, if the proposed solution is approved.

Member

Maks3w commented Dec 3, 2012

Please send the patch and a test case for avoid regressions.

stefanotorresi added some commits Dec 10, 2012

@stefanotorresi stefanotorresi add id attribute handling
provides html 'id' attribute uniqueness via a hardcoded suffix
2f66222
@stefanotorresi stefanotorresi cs fix 89a3a9d

@ghost ghost assigned Maks3w and weierophinney Dec 11, 2012

@weierophinney weierophinney added a commit that referenced this pull request Dec 11, 2012

@weierophinney weierophinney Merge branch 'hotfix/3144' into develop
Forward port #3144
38a4b42

@weierophinney weierophinney added a commit that referenced this pull request Dec 11, 2012

@weierophinney weierophinney Merge branch 'hotfix/3144'
Close #3144
e81f91e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment