Fixed DefinitionList::hasMethod() #3329

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@neeckeloo
Contributor

The method DefinitionList::hasMethods() was simply duplicated to create method DefinitionList::hasMethod() and therefore it did not work correctly.

@neeckeloo neeckeloo closed this Jan 2, 2013
@neeckeloo
Contributor

I just realize that this bug was fixed recently, but maybe this pull requests may interest you since I refactored some methods and added unit tests.

@neeckeloo neeckeloo reopened this Jan 2, 2013
@Ocramius
Member
Ocramius commented Jan 2, 2013

@neeckeloo what do you mean by "did not work correctly"? It may be useful to just have the tests to avoid regressions.

@neeckeloo
Contributor

I was referring to #3229 which fixed the fact that the method DefinitionList::hasMethod() has the same behavior as the method DefinitionList::hasMethods().

I updated unit tests.

@weierophinney weierophinney added a commit that referenced this pull request Jan 4, 2013
@weierophinney weierophinney Merge branch 'hotfix/3329' into develop
Forward port #3329
af768c1
@weierophinney weierophinney added a commit that closed this pull request Jan 4, 2013
@weierophinney weierophinney Merge branch 'hotfix/3329'
Close #3329
ab62f84
@weierophinney weierophinney was assigned Jan 4, 2013
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3329' 8553b0b
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3329' into develop 71d8d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment