render view one last time in case exception thrown from inside view #3385

Merged
merged 4 commits into from Jan 14, 2013

Conversation

Projects
None yet
2 participants
@radnan
Contributor

radnan commented Jan 9, 2013

Try to render the view one last time in case a render.error is triggered by an exception from within the view or one of the child views. If the view continues to throw exceptions, bail out and just re-throw the exception.

radnan added some commits Jan 9, 2013

render view one last time in case of render.error
Try to render the view one last time in case a render.error is
triggered. If the view continues to throw exceptions, bail out and
just re-throw the exception.

@radnan radnan referenced this pull request Jan 9, 2013

Merged

Feature/render listener #2959

+ $e->setError(Application::ERROR_EXCEPTION)
+ ->setParam('exception', $ex);
+ $events->trigger(MvcEvent::EVENT_RENDER_ERROR, $e);
+ }

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jan 14, 2013

Member

You don't need an else block here; if the condition is met, it won't run continue further regardless.

@weierophinney

weierophinney Jan 14, 2013

Member

You don't need an else block here; if the condition is met, it won't run continue further regardless.

weierophinney added a commit that referenced this pull request Jan 14, 2013

@weierophinney weierophinney merged commit 93b5784 into zendframework:develop Jan 14, 2013

1 check failed

default The Travis build failed
Details

@ghost ghost assigned weierophinney Jan 14, 2013

weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment