Update library/Zend/Validator/Hostname.php #3445

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

Contributor
grizzm0 commented Jan 16, 2013

EdpSuperluminal fails due to faulty path.

Warning: include(Hostname/Com.php): failed to open stream: No such file or directory in /path/to/application/data/cache/classes.php.cache on line 2
Warning: include(): Failed opening 'Hostname/Com.php' for inclusion (include_path='.:/usr/local/share/pear') in /path/to/application/data/cache/classes.php.cache on line 2
Fatal error: Unsupported operand types in /path/to/application/data/cache/classes.php.cache on line 2

Member

@grizzm0 tests please!

Owner

The hostname validator relies on files that contain arrays of valid regexes for given TLDs. Those files are located in a subdirectory relative to the validator itself. This is why EdpSuperluminal fails in that regard.

@grizzm0 As @Ocramius noted, we need tests before we can accept this patch.

Contributor
grizzm0 commented Jan 23, 2013

@weierophinney rebased and tests passed.

@weierophinney weierophinney added a commit that referenced this pull request Jan 25, 2013
@weierophinney weierophinney Merge branch 'hotfix/3445' into develop
Forward port #3445
bdfe2fc
@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3445' 800c29c
@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3445' into develop fd9fad0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment