Update library/Zend/Validator/Hostname.php #3445

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@grizzm0
Contributor

grizzm0 commented Jan 16, 2013

EdpSuperluminal fails due to faulty path.

Warning: include(Hostname/Com.php): failed to open stream: No such file or directory in /path/to/application/data/cache/classes.php.cache on line 2
Warning: include(): Failed opening 'Hostname/Com.php' for inclusion (include_path='.:/usr/local/share/pear') in /path/to/application/data/cache/classes.php.cache on line 2
Fatal error: Unsupported operand types in /path/to/application/data/cache/classes.php.cache on line 2

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jan 18, 2013

Member

@grizzm0 tests please!

Member

Ocramius commented Jan 18, 2013

@grizzm0 tests please!

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jan 21, 2013

Member

The hostname validator relies on files that contain arrays of valid regexes for given TLDs. Those files are located in a subdirectory relative to the validator itself. This is why EdpSuperluminal fails in that regard.

@grizzm0 As @Ocramius noted, we need tests before we can accept this patch.

Member

weierophinney commented Jan 21, 2013

The hostname validator relies on files that contain arrays of valid regexes for given TLDs. Those files are located in a subdirectory relative to the validator itself. This is why EdpSuperluminal fails in that regard.

@grizzm0 As @Ocramius noted, we need tests before we can accept this patch.

@grizzm0

This comment has been minimized.

Show comment Hide comment
@grizzm0

grizzm0 Jan 23, 2013

Contributor

@weierophinney rebased and tests passed.

Contributor

grizzm0 commented Jan 23, 2013

@weierophinney rebased and tests passed.

@ghost ghost assigned weierophinney Jan 25, 2013

weierophinney added a commit that referenced this pull request Jan 25, 2013

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

@grizzm0 grizzm0 deleted the grizzm0:patch-1 branch Jun 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment