fix for zendframework/zf2#3458 #3461

Merged
merged 1 commit into from Jan 17, 2013

Conversation

Projects
None yet
3 participants
Contributor

netiul commented Jan 17, 2013

Member

Maks3w commented Jan 17, 2013

Please add a test case

Contributor

netiul commented Jan 17, 2013

@Maks3w test added to commit

@weierophinney weierophinney added a commit that referenced this pull request Jan 17, 2013

@weierophinney weierophinney [#3461] CS fixes
- Trailing whitespace
ddb8f73

@weierophinney weierophinney added a commit that referenced this pull request Jan 17, 2013

@weierophinney weierophinney [#3461] PHPUnit test fix
- $_SESSION is not always present from CLI and/or PHPUnit; check to see
  if it exists before using it. This prevents:
    - notice (undefined variable)
    - catchable fatal error (toArray returning null, which is then
      passed to fromArray() which expects an array)
a4295ec

weierophinney merged commit eae50fd into zendframework:develop Jan 17, 2013

1 check failed

default The Travis build failed
Details

@weierophinney weierophinney added a commit that referenced this pull request Jan 17, 2013

@weierophinney weierophinney [#3461] CS fixes
- trailing whitespace
ec87f64

@weierophinney weierophinney added a commit that referenced this pull request Jan 17, 2013

@weierophinney weierophinney Merge branch 'hotfix/3461'
Backport #3461 to master
b571e63
Owner

weierophinney commented Jan 17, 2013

Realized this belonged on master as well, so cherry-picked the commit into master.

@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#3461] CS fixes
- Trailing whitespace
f33d770

@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#3461] PHPUnit test fix
- $_SESSION is not always present from CLI and/or PHPUnit; check to see
  if it exists before using it. This prevents:
    - notice (undefined variable)
    - catchable fatal error (toArray returning null, which is then
      passed to fromArray() which expects an array)
5801b5b

@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/3461' into develop 1c82c93

@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#3461] CS fixes
- trailing whitespace
94011c7

@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/3461' 1b48124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment