remove surplus call deep namespace #3473

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

samsonasik commented Jan 17, 2013

because already defined in 'use' statement

samsonasik added some commits Jan 17, 2013

@samsonasik samsonasik remove surplus namespace
because already defined in 'use' statement
8b20094
@samsonasik samsonasik remove deep namespace docblock
in ControllerLoaderFactory.php
61452b2

@Maks3w Maks3w commented on the diff Jan 19, 2013

library/Zend/Mvc/Service/ControllerLoaderFactory.php
@@ -25,7 +25,7 @@ class ControllerLoaderFactory implements FactoryInterface
/**
* Create the controller loader service
*
- * Creates and returns an instance of Controller\ControllerManager. The
+ * Creates and returns an instance of ControllerManager. The
@Maks3w

Maks3w Jan 19, 2013

Member

I prefer to have the entire name to avoid conflicts between two namespaces with the same class name

@samsonasik

samsonasik Jan 19, 2013

Contributor

@Maks3w : should I change to \Zend\Mvc\Controller\ControllerManager ?

@samsonasik

samsonasik Jan 21, 2013

Contributor

@Maks3w : in use statement, it already defined as 'use Zend\Mvc\Controller\ControllerManager', cmiiw.

@weierophinney

weierophinney Jan 21, 2013

Owner

It's correct in here as-is, as the ControllerManager class is imported into the current file.

@weierophinney weierophinney added a commit that referenced this pull request Jan 21, 2013

@weierophinney weierophinney Merge branch 'hotfix/3473' into develop
Forward port #3473
60845bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment