[2.1] fixed tons of missing/wrong use statements #3496

Merged
merged 7 commits into from Jan 21, 2013

3 participants

@marc-mabe
Zend Framework member

On the following errors I need help to resolve

  • Zend\Db\Metadata\Source\AbstractSource uses the not existing class Object\ConstraintKeyObject
  • Zend\XmlRpc\Server\Exception\Stdin::____construct() uses new ServerException which is defined as use Zend\XmlRpc\Server\Exception as ServerException
  • Zend\XmlRpc\AbstractValue::_phpVarToNativeXmlRpc checks against the not existing class Zend\Math\BigInteger
@bakura10 bakura10 commented on the diff Jan 19, 2013
...est/PHPUnit/Controller/AbstractControllerTestCase.php
@@ -180,7 +181,7 @@ public function getRequest()
/**
* Get the application response object
- * @return \Zend\Stdlib\ResponseInterface
+ * @return ResponseInterface
@bakura10
bakura10 added a line comment Jan 19, 2013

I think we do not add a use just for something that is in a comment (at least someone told me not to do one day).

@weierophinney
Zend Framework member
weierophinney added a line comment Jan 20, 2013
@Maks3w
Zend Framework member
Maks3w added a line comment Jan 20, 2013

Doing this we miss the possibility of scan use statements for detect direct dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@weierophinney weierophinney merged commit c7b9777 into zendframework:develop Jan 21, 2013

1 check passed

Details default The Travis build passed
@Maks3w Maks3w pushed a commit that referenced this pull request Jan 21, 2013
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop
Close #3496
d1e0897
@marc-mabe
Zend Framework member

@weierophinney @Maks3w What about the unresolved errors I wrote about in PR description?

@Maks3w
Zend Framework member

@marc-mabe Can you open different issues for that?

@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop
Close #3496
12dfa89
@weierophinney weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop 2795a1b
@weierophinney weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop 044d319
@weierophinney weierophinney added a commit to zendframework/zend-xmlrpc that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop 2f99dd8
@weierophinney weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop f7f0423
@weierophinney weierophinney added a commit to zendframework/zend-session that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop b8939bd
@weierophinney weierophinney added a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3496' into develop e8c607f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment