removed "self" typehints in Zend\Config and Zend\Mvc #3499

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@prolic
Contributor
prolic commented Jan 20, 2013

This one is related to: #2977

@blanchonvincent blanchonvincent commented on the diff Jan 21, 2013
library/Zend/Config/Config.php
@@ -343,7 +343,7 @@ public function offsetUnset($offset)
* @param Config $merge
* @return Config
*/
- public function merge(self $merge)
+ public function merge(Config $merge)
{
blanchonvincent
blanchonvincent Jan 21, 2013 Contributor

Just out of curiosity, why it is better ?

prolic
prolic Jan 21, 2013 Contributor

This is related to: #2977

blanchonvincent
blanchonvincent Jan 21, 2013 Contributor

Thank you

@weierophinney weierophinney added a commit that referenced this pull request Jan 21, 2013
@weierophinney weierophinney Merge branch 'hotfix/3499' into develop
Forward port #3499
19d9156
@weierophinney weierophinney added a commit that closed this pull request Jan 21, 2013
@weierophinney weierophinney Merge branch 'hotfix/3499'
Close #3499
Fixes #2977
d0321dd
Owner

I cherry-picked so we could put it in master as well. Thanks, @prolic

@prolic prolic deleted the prolic:typehints branch Jan 21, 2013
@weierophinney weierophinney added a commit to zendframework/zend-config that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3499' 69fb7fc
@weierophinney weierophinney added a commit to zendframework/zend-config that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3499' into develop a6e6d31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment