Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ZF2-52: ::regenerateId() fails and ::rememberMe() clears session storage #352

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Member

Thinkscape commented Aug 22, 2011

Fixes this: http://framework.zend.com/issues/browse/ZF2-52

Also added optional parameter to SessionManager::start() to allow starting new session without clearing current session storage.

Owner

weierophinney commented Aug 25, 2011

Reviewed, merged, and pushed -- thanks!

I don't see to much logic in this metod at this time :) IF in this method is not necessary..

Member

Thinkscape replied Feb 6, 2012

It's required for proper branching. If in doubt, you could run "find usages" and debug the tests I've added along with this PR.

DeyV replied Feb 7, 2012

But now method regenerateId() should look simple:

regenerateId() {
session_regenerate_id();
return $this;
}

"If" nothing changes ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment