Remove useless shared in ServiceManager #3663

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

blanchonvincent commented Feb 4, 2013

Shared or not a service as no sense, because a service shared is
register in "instances" array, and "setService" register automatically
in "instances" array. With "setService", all is always shared !

Remove useless shared in ServiceManager
Shared or not a service as no sense, because a service shared is
register in "instances" array, and "setService" register automatically
in "instances" array. With "setService", all is always shared !
Member

Maks3w commented Feb 4, 2013

Please revert unrelated changes.

Contributor

samsonasik commented Feb 4, 2013

@blanchonvincent I think you've use php-cs-fixer. my suggestion is to revert it and run php-cs-fixer with only fix trailing_spaces :

php php-cs-fixer.phar fix /path/to/dir/file.ext --fixers=trailing_spaces
Member

Maks3w commented Feb 4, 2013

@samsonasik The correct argument for ZF2 is --level=psr2

Contributor

samsonasik commented Feb 4, 2013

@Maks3w thanks ;)

Contributor

blanchonvincent commented Feb 5, 2013

@Maks3w @samsonasik I use always --level=psr2 but i revert unrelated change now

Contributor

samsonasik commented Feb 5, 2013

👍

weierophinney added a commit that referenced this pull request Feb 5, 2013

@ghost ghost assigned weierophinney Feb 5, 2013

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment