Allow NULL parameter values in Zend/Json/Server #3767

Closed
wants to merge 3 commits into from

4 participants

@Maks3w
Zend Framework member

@djskinner Various things.

  • doing rebase -i HEAD~3 you should able to remove the extra commit.
  • Check your lineendings all the file looks changed. The correct lineending for ZF2 is "\n"
@ralphschindler
Zend Framework member

@djskinner if you can clean this up, we can evaluation its inclusion in 2.1.2

@weierophinney
Zend Framework member

@djskinner I would love to include this, but:

  • I need a unit test detailing the behavior (it will also be used to ensure we don't have a future regression in behavior)
  • I need you to fix the line endings, so that the patch only shows what has changed. Right now, I have no idea where the change is.
@djskinner djskinner closed this Feb 26, 2013
@djskinner djskinner reopened this Feb 26, 2013
@djskinner

Just in the process of tidying this up and doing it properly.

djskinner added some commits Feb 26, 2013
@djskinner djskinner Allow NULL parameter values in Zend/Json/Server
Allow NULL as an acceptable value for non-optional method parameters.
28492a8
@djskinner djskinner Added test case b12dd9f
@djskinner

@Maks3w @ralphschindler @weierophinney

Ok guys, pull request tidied and test case added. Anything else?

@Maks3w Maks3w commented on an outdated diff Feb 28, 2013
tests/ZendTest/Json/ServerTest.php
@@ -259,6 +259,20 @@ public function testHandleValidMethodShouldWork()
$this->assertFalse($response->isError());
}
+ public function testHandleValidMethodWithNULLParamValueShouldWork()
@Maks3w
Zend Framework member
Maks3w added a note Feb 28, 2013

Check this character, should be 4 spaces and now is a tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Maks3w
Zend Framework member

For me is good. I'll let the final decision to @ralphschindler

@djskinner The main reason for this delay is that GitHub doesn't notify us when a PR is modified. Just notify for comments.

@djskinner

I've added another commit to fix the formatting issue.

@weierophinney weierophinney was assigned Mar 1, 2013
@weierophinney weierophinney added a commit that referenced this pull request Mar 1, 2013
@weierophinney weierophinney [#3767] CS fixes
- indentation, trailing_spaces
ed5baa6
@weierophinney weierophinney added a commit that referenced this pull request Mar 1, 2013
@weierophinney weierophinney Merge branch 'hotfix/3767' into develop
Forward port #3767
d883690
@weierophinney weierophinney added a commit that closed this pull request Mar 1, 2013
@weierophinney weierophinney Merge branch 'hotfix/3767'
Close #3767
Fixes #3696
Fixes #2752
e09ba97
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney [#3767] CS fixes
- indentation, trailing_spaces
617a1a6
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/3767'
Close #3767
Fixes #3696
Fixes #2752
97df372
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/3767' into develop
Forward port #3767
8db988b
@weierophinney weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#3767] CS fixes
- indentation, trailing_spaces
2a2cbdb
@weierophinney weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/3767' into develop 6d4e64c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment