Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[#3711] Fix regression in query string matching #3778

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

weierophinney commented Feb 13, 2013

If a route is marked may_terminate, and a query string is present, in
most cases, we should match; the query route is primarily for the
convenience of generating URIs via the assemble() method, and only
matches if a query string is present.

This patch adds tests that do the following:

  • If the route is marked may_terminate and a query string is present,
    but there is no Query route child, match and return immediately.
  • If the route is marked may_terminate, and a query string is present,
    and a Query route child is present, pass matching on to child routes.

This fixes #3711 and replaces #3712

@weierophinney weierophinney [#3711] Fix regression in query string matching
If a route is marked may_terminate, and a query string is present, in
most cases, we should match; the query route is primarily for the
convenience of _generating_ URIs via the assemble() method, and only
matches if a query string is present.

This patch adds tests that do the following:

- If the route is marked may_terminate and a query string is present,
  but there is no Query route child, match and return immediately.
- If the route is marked may_terminate, and a query string is present,
  and a Query route child is present, pass matching on to child routes.
f9fad6e

@ghost ghost assigned ralphschindler Feb 15, 2013

@ralphschindler ralphschindler added a commit that referenced this pull request Feb 19, 2013

@ralphschindler ralphschindler Forward #3778
Merge branch 'weierophinney-hotfix/3711' into develop
0823436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment