Paginator: Group by must be reseted #3791

Merged
merged 2 commits into from Feb 15, 2013

Conversation

Projects
None yet
2 participants
Contributor

ThaDafinser commented Feb 15, 2013

The group by part has also to be reseted, when COUNT(1) is used

Contributor

ThaDafinser commented Feb 15, 2013

Otherwise the count() result will be wrong.

For reference see ZF1 (there is was correct)

ralphschindler merged commit 5ddc4e9 into zendframework:master Feb 15, 2013

1 check passed

default The Travis build passed
Details

@ralphschindler ralphschindler added a commit that referenced this pull request Feb 15, 2013

@ralphschindler ralphschindler Forward #3791
Merge branch 'ThaDafinser-patch-3' into develop
dec8ec5
Member

ralphschindler commented Jun 12, 2013

There have been improvements to the Zend\Paginator\Adapter\DbSelect that have moved into master (for 2.2.1). Basically, DbSelect moved to a subselect solution, which is more portable. Please see these issues: #4641, #4590, and #3647.

@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015

@ralphschindler ralphschindler Forward zendframework/zendframework#3791
Merge branch 'ThaDafinser-patch-3' into develop
616a69c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment