Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Hotfix/zend test improve console usage #3842

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

blanchonvincent commented Feb 20, 2013

Keep the code more clean with Console::overrideIsConsole :)

Member

Freeaqingme commented Mar 6, 2013

@blanchonvincent Thank you for this pull request!

Given that you're using a static, could you perhaps add a teardown method that resets the value of this static to its original value (null)? That'll ensure other (future) tests won't be affected by this unit test.

Contributor

blanchonvincent commented Mar 8, 2013

@Freeaqingme thank you for the feedback, i updated the PR to restore initial flag.

@weierophinney weierophinney was assigned Mar 8, 2013

@weierophinney weierophinney added a commit that referenced this pull request Mar 11, 2013

@weierophinney weierophinney [#3842] CS fixes
- trailing whitespace
cb1da69

@weierophinney weierophinney added a commit that referenced this pull request Mar 11, 2013

@weierophinney weierophinney Merge branch 'hotfix/3842' into develop
Forward port #3842
53768a3

@curious-eyes curious-eyes added a commit to curious-eyes/zf2 that referenced this pull request Mar 18, 2013

@weierophinney @curious-eyes weierophinney + curious-eyes [#3842] CS fixes
- trailing whitespace
c91be34

@weierophinney weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#3842] CS fixes
- trailing whitespace
750861f

@weierophinney weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/3842' d6c4730

@weierophinney weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/3842' into develop 5db46c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment