Fix #3852 #3855

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

SocalNick commented Feb 21, 2013

Added test case from the aforementioned issue.
No longer reversing regex as it was problematic for constraints.
Fixing expectation for two optional subdomains with one missing.
Adding test cases for nested subdomains.

@SocalNick SocalNick Fix #3852
Added test case from the aforementioned issue.
No longer reversing regex as it was problematic for constraints.
Fixing expectation for two optional subdomains with one missing.
Adding test cases for nested subdomains.
eb594ab

@DASPRiD DASPRiD commented on an outdated diff Feb 21, 2013

library/Zend/Mvc/Router/Http/Hostname.php
@@ -287,7 +287,7 @@ public function match(Request $request)
foreach ($this->paramMap as $index => $name) {
if (isset($matches[$index]) && $matches[$index] !== '') {
// reverse the param as the preg_match was done on reverse host
@DASPRiD

DASPRiD Feb 21, 2013

Member

The reverse comments should likely be removed in all places now :)

@weierophinney weierophinney added a commit that referenced this pull request Feb 21, 2013

@weierophinney weierophinney Merge branch 'hotfix/3855' into develop
Forward port #3855
b4fdf9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment