Remove BC break in Identical validator #3869

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@bakura10
Contributor

bakura10 commented Feb 22, 2013

A BC break was introduced a few days ago in Identical component (fcbe185#library/Zend/Validator/Identical.php).

My use case which was valid was specifying the token as a single value:

$inputFilter->add(array(
            'name'       => 'accept',
            'validators' => array(
                array(
                    'name'    => 'Identical',
                    'options' => array(
                        'token' => '1',
                        'messages' => array(
                            'notSame' => 'Vous devez d\'abord accepter la charte de Capitaine Job !'
                        )
                    )
                )
            )
        ));

However this was not accepted anymore because it threw in exception.

@iquabius

This comment has been minimized.

Show comment Hide comment
@iquabius

iquabius Feb 22, 2013

Contributor

I added a option to make this possible - #3844. But I think the BC break won't allow it!

Contributor

iquabius commented Feb 22, 2013

I added a option to make this possible - #3844. But I think the BC break won't allow it!

@ghost ghost assigned weierophinney Mar 8, 2013

weierophinney added a commit that referenced this pull request Mar 11, 2013

Merge pull request #3869 from bakura10/remove-identical-bc
Remove BC break in Identical validator

weierophinney added a commit that referenced this pull request Mar 11, 2013

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#3869 from bakura10/rem…
…ove-identical-bc

Remove BC break in Identical validator

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment