Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Class was supporting limit + offset or limit, but only offset does not support #4032

Merged
merged 1 commit into from Apr 30, 2013

Conversation

Projects
None yet
2 participants
Contributor

romulobusatto commented Mar 14, 2013

Class was supporting limit + offset or limit, but only offset does not support

@romulobusatto romulobusatto Update SelectDecorator.php
Class was supporting limit + offset or limit, but only offset does not support
e7a2618
Member

ralphschindler commented Mar 15, 2013

Can you provide me with some code use cases to better understand the fix here?
Are you saying it wont work if offset is used without limit?

Contributor

romulobusatto commented Mar 15, 2013

yes, only use off, as in the example below will not work.
Sample:
$sql = new Sql($adapter);
$select = $sql->select();
$select->from('album');
$select->offset(5);

@ralphschindler ralphschindler added a commit that referenced this pull request Apr 30, 2013

@ralphschindler ralphschindler PR #4032
Merge branch 'master' of git://github.com/romulobusatto/zf2 into romulobusatto-master
86a6e66

@ralphschindler ralphschindler added a commit that referenced this pull request Apr 30, 2013

@ralphschindler ralphschindler PR #4032
Merge branch 'romulobusatto-master'
af7f7b0

@ralphschindler ralphschindler merged commit e7a2618 into zendframework:master Apr 30, 2013

1 check failed

default The Travis build could not complete due to an error
Details

@ralphschindler ralphschindler added a commit that referenced this pull request Apr 30, 2013

@ralphschindler ralphschindler Forward #4032
Merge branch 'romulobusatto-master' into develop
cbda160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment