Moved ext-intl to suggest instead of require to avoid silent fallback. #4048

Merged
merged 1 commit into from Mar 27, 2013

Projects

None yet

2 participants

@spiffyjr
Contributor

No description provided.

@weierophinney
Member

What's the "silent fallback," exactly?

@spiffyjr
Contributor

If you don't have the intl extension installed composer will notice a failure and fallback to the primary zf2 repository silently. Moving ext-intl to suggests accomplishes two things:

  1. The user will receive a suggestion to install i18n (avoiding a fatal_error with no info with the fallback).
  2. The "silent fallback" will be avoided.
@weierophinney weierophinney added a commit that referenced this pull request Mar 27, 2013
@weierophinney weierophinney Merge branch 'hotfix/4048' into develop
Close #4048
4a9105b
@weierophinney weierophinney merged commit 5c5d650 into zendframework:develop Mar 27, 2013
@spiffyjr spiffyjr deleted the unknown repository branch Mar 28, 2013
@weierophinney weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#4048 from spiffyjr/hot…
…fix/i18n-composer

Moved ext-intl to suggest instead of require to avoid silent fallback.

Conflicts:
	library/Zend/I18n/composer.json
41482ea
@weierophinney weierophinney added a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/4048' into develop afb9ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment