Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Catch LogicException for Rewind and fix CP errors #4154

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

mvriel commented Mar 30, 2013

The rewind method is, as the valid() method, affected by an issue
with the GlobIterator where it throws a LogicException if the dataset
is empty (https://bugs.php.net/bug.php?id=55701).

This exception should be caught and correctly returned as this will
interfere with foreach statements at the invoker.

In addition to the above have several copy-paste errors in the
DocBlocks been fixed.

Catch LogicException for Rewind and fix CP errors
The rewind method is, as the valid() method, affected by an issue
with the GlobIterator where it throws a LogicException if the dataset
is empty (https://bugs.php.net/bug.php?id=55701).

This exception should be caught and correctly returned as this will
interfere with foreach statements at the invoker.

In addition to the above have several copy-paste errors in the 
DocBlocks been fixed.
Contributor

mvriel commented Mar 30, 2013

The failed travis build is not due to a failed unit test but some weirdness in the 5.3.3 build

@ghost ghost assigned weierophinney Apr 12, 2013

weierophinney added a commit that referenced this pull request Apr 12, 2013

Owner

weierophinney commented Apr 12, 2013

This actually applies against master as well, so I took the liberty of cherry-picking the commit to ensure it makes it into 2.1.5 as well.

Thanks, Mike!

weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment