Add coveralls support and fix a few testing bugs related to coverage #4397

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
6 participants
Member

DASPRiD commented May 3, 2013

This PR adds coveralls support (https://coveralls.io/) to ZF2. This tool integrates nicely with both GitHub and Travis, and allows us to keep track of our code coverage.

In the same run I fixed a few broken @covers annotations and a bug which prevented complete testing on Ubuntu 12.04 (see comments in the diff).

Coveralls status can be found at https://coveralls.io/r/zendframework/zf2

Member

DASPRiD commented May 3, 2013

Mhh, something's still wrong with composer it seems.

satooshi commented May 4, 2013

Please try to set src_dir: library in .coveralls.yml.

Member

DASPRiD commented May 4, 2013

Oh indeed, I totally forgot that we have "library" as source folder, thanks.

Member

DASPRiD commented May 4, 2013

Oh, just saw that you are the developer of php-coveralls, nice work on that!

Coverage Status

Changes Unknown when pulling 43e9a61 on DASPRiD:feature/coveralls-support into * on zendframework:master*.

@@ -8,6 +8,27 @@
],
"homepage": "http://framework.zend.com/",
"license": "BSD-3-Clause",
+ "repositories": [
@prolic

prolic May 6, 2013

Contributor

phpcov comes without composer support. perhabs someone can make a PR there first?

@Ocramius

Ocramius May 7, 2013

Member

For sure a requirement before this goes in

@DASPRiD

DASPRiD May 7, 2013

Member

Well, at least we are already on a stable tag here ;)

@@ -16,7 +37,9 @@
"ircmaxell/random-lib": "dev-master",
"ircmaxell/security-lib": "dev-master",
"ocramius/proxy-manager": "0.3.*",
- "phpunit/PHPUnit": "3.7.*"
+ "phpunit/PHPUnit": "3.7.*",
+ "satooshi/php-coveralls": "dev-master",
@Ocramius

Ocramius May 6, 2013

Member

use a stable tag please

Member

DASPRiD commented May 7, 2013

Related issue, should be fixed soon (as in, today or tomorrow):
lemurheavy/coveralls-public#51

weierophinney added a commit that referenced this pull request Jun 28, 2013

Merge pull request #4397 from DASPRiD/feature/coveralls-support
Add coveralls support and fix a few testing bugs related to coverage

weierophinney added a commit that referenced this pull request Jun 28, 2013

[#4397] CS fixes
- EOF ending
- trailing whitespace

weierophinney added a commit that referenced this pull request Jun 28, 2013

@ghost ghost assigned weierophinney Jun 28, 2013

Owner

weierophinney commented Jun 28, 2013

Merged to develop for 2.3.0 release.

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#4397 from DASPRiD/feat…
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#4397 from DASPRiD/feat…
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015

Merge pull request zendframework/zendframework#4397 from DASPRiD/feat…
…ure/coveralls-support

Add coveralls support and fix a few testing bugs related to coverage

weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015

[zendframework/zendframework#4397] CS fixes
- EOF ending
- trailing whitespace

weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request May 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment