Fixed unnecessary error rendering in form row helper. #4441

Closed
wants to merge 1 commit into from

2 participants

@glen-84

No description provided.

@weierophinney
Zend Framework member

Please add a unit test for this functionality.

@glen-84

@weierophinney

I didn't add any functionality, isn't this already covered by "testDoesNotRenderErrorsListIfSetToFalse"?

@weierophinney
Zend Framework member

@glen-84 That test was already passing, which means that we need to give it additional input covering the use case that would trigger the issue of errors rendering.

@glen-84

@weierophinney How would I test if a method was invoked ($elementErrorsHelper->render()), is this even possible? My changes have no effect on the output of the helper.

@weierophinney weierophinney was assigned May 9, 2013
@weierophinney weierophinney added a commit that closed this pull request May 9, 2013
@weierophinney weierophinney Merge branch 'hotfix/4441'
Close #4441
3af6f8c
@weierophinney weierophinney added a commit that referenced this pull request May 9, 2013
@weierophinney weierophinney Merge branch 'hotfix/4441' into develop
Forward port #4441
76b17d1
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/4441'
Close #4441
fa19a2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment