Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Introduce JsonSerializable polyfill and support in Zend\Json\Encoder #4534

Merged
merged 2 commits into from May 23, 2013
Merged

Introduce JsonSerializable polyfill and support in Zend\Json\Encoder #4534

merged 2 commits into from May 23, 2013

Conversation

gws
Copy link
Contributor

@gws gws commented May 23, 2013

This is an alternative to #4507

It introduces a polyfill into Zend\Stdlib which can be used by legacy PHP implementations. Zend\Json\Encoder then tests for the PHP built-in interface which will work even on PHP implementations where \JsonSerializable doesn't exist.

@gws
Copy link
Contributor Author

gws commented May 23, 2013

ZF2 convention is to use the Interface suffix for interfaces, which I did not do in the Zend\Stdlib polyfill because of the naming of the native class, but I could see arguments for both sides.

weierophinney added a commit that referenced this pull request May 23, 2013
Introduce JsonSerializable polyfill and support in Zend\Json\Encoder
weierophinney added a commit that referenced this pull request May 23, 2013
@weierophinney weierophinney merged commit ff34a09 into zendframework:develop May 23, 2013
@ghost ghost assigned weierophinney May 23, 2013
@weierophinney
Copy link
Member

@gwis we did not follow the "Interface" suffix in other polyfills, either. :)

Merged to develop for release in 2.3.0. Thanks!

@gws gws deleted the feature/jsonserializable-polyfill branch May 23, 2013 18:49
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
…/jsonserializable-polyfill

Introduce JsonSerializable polyfill and support in Zend\Json\Encoder
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
…/jsonserializable-polyfill

Introduce JsonSerializable polyfill and support in Zend\Json\Encoder
weierophinney added a commit to zendframework/zend-json that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants